fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911mikepitre wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthrough
ChangesiOS podspec dependency fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4736874 to
9d32c83
Compare
🦋 Changeset detectedLatest commit: 9d32c83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
Summary
Adds
ExpoModulesCoreas an explicit dependency of the iOSClerkGoogleSignInpod.Why
After #8901,
ClerkGoogleSignInModule.swiftbecame an Expo module and now importsExpoModulesCore:import ExpoModulesCoreThe
ClerkGoogleSignInpodspec did not declareExpoModulesCoredirectly, so the generated Podfile could includeExpoModulesCoreelsewhere in the app while theClerkGoogleSignInpod target still could not import it.This shows up at Xcode compile time, not during prebuild or pod install:
node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore' import ExpoModulesCore ^Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for
ClerkGoogleSignIn.Validation
I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the
ExpoModulesCoredependency fromClerkGoogleSignIn.podspec.Without this change:
npx expo prebuild --clean --platform iospassednpx expo run:ios --no-bundlerfailed withno such module 'ExpoModulesCore'Podfile.lockshowedExpoModulesCoreexisted globally, but not underClerkGoogleSignInWith this change:
npx expo prebuild --clean --platform iospassedPodfile.lockshowedClerkGoogleSignIndirectly depends onExpoModulesCorenpx expo run:ios --no-bundlerpassedAlso ran:
pnpm --filter @clerk/expo format:checkgit diff --checkNote: local shell reports Node
v22.12.0, while the repo asks for>=24.15.0.