Skip to content

#90 - FileFetchTaskTest: no more PHPUnit notices #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njoubert-cleverage merged 1 commit into from
Nov 2, 2026
Merged

#90 - FileFetchTaskTest: no more PHPUnit notices #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/Task/FileFetchTaskTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,15 @@ public function testWriteFailureKeepsSourceAndFails(): void

public function testUnknownStorageFailsAtInitialization(): void
{
$this->destination->expects($this->never())->method('writeStream');
$this->source->expects($this->never())->method('delete');
$state = $this->createState('unknown');
$state->expects($this->never())->method('setOutput');
$task = $this->createTask();

$this->expectException(UnexpectedValueException::class);
$this->expectExceptionMessage('Unknown storage "unknown" (option "destination_filesystem"), known storages: "source", "destination"');
$task->initialize($this->createState('unknown'));
$task->initialize($state);
}

public function testTaskFailsExplicitlyWhenExecutedAfterAFailedInitialization(): void
Expand All @@ -85,6 +89,8 @@ public function testTaskFailsExplicitlyWhenExecutedAfterAFailedInitialization():
}

$this->destination->expects($this->never())->method('writeStream');
$this->source->expects($this->never())->method('delete');
$state->expects($this->never())->method('setOutput');
$this->expectException(UnexpectedValueException::class);
$this->expectExceptionMessage('The storages of the task are not available: its initialization has failed, see the previous error');
$task->execute($state);
Expand Down
Loading