Repository navigation
#94 - flysystem_list_content: read the listing item by item - #95
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #94:
ListContentTask::getFilteredFilesystemContents()is a generator iterating the Flysystem listing; same output and order, same behaviour for an empty listing or no matching item; each new execution lists again;list_content_task.md: with an adapter listing lazily, files removed during the iteration (e.g. by aflysystem_remove_filetask downstream) may change the listing.Checked locally: highest dependencies (PHP 8.5.12), with pcov coverage: all tests OK, no risky; PHPStan, PHP-CS-Fixer and Rector OK.
Requirements
Breaking changes
The protected
$fsContentandgetFilteredFilesystemContents()(class@finalsince 3.3) now hold / return aGenerator.🤖 Generated with Claude Code