fix(joint-react): stop guarding events targeting paper container itself - #3476
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes React Paper event guarding so events targeting the paper container itself reach JointJS while portaled descendants remain guarded.
Changes:
- Excludes
paper.elfrom portaled-content detection. - Adds regression tests for container events and wheel panning.
- Adds an
@joint/reactpatch changeset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/joint-react/src/presets/paper.ts |
Corrects event target guarding. |
packages/joint-react/src/components/paper/__tests__/paper-html-content-events.test.tsx |
Adds regression coverage. |
.changeset/lucky-pans-listen.md |
Documents the patch release. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kumilingus
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the paper preset's
guardExplicitoverride treatingpaper.elitself as portaled content (becauseNode.contains()is true for the node itself, so the check meant for descendants also caught the root element, guarding it before joint-core's guard() could reach itsthis.el === targetexemption).Adds regression tests for the boundary; real portaled content stays guarded.
Motivation and Context
This fixes a failing test in joint-react-plus.