Repository navigation
Update sqlite3 to 2.9.6 - #31
Merged
Merged
Conversation
Keeps the test database driver on a supported release line so we pick up upstream SQLite and security fixes instead of staying pinned to 1.x. The pin moves from the gemspec to the Gemfile so the Active Record 7.0 appraisal can override it: AR 7.0's SQLite adapter refuses to load with sqlite3 2.x (it requires ~> 1.4), and a gemspec dependency cannot be overridden per appraisal.
anthonyoconnorclio
marked this pull request as ready for review
October 13, 2026 23:02
hype08
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The gemspec pinned sqlite3 to
~> 1.4, which Overlord flags with two open CVE alerts. 2.9.6 is the first release that fixes both.Both can cause a segfault or pass an incorrect value to custom SQLite functions/aggregates. Neither is known to be exploited. sqlite3 is a development dependency only, so it is not shipped with the gem.
Notes for reviewers
Active Record 7.0's SQLite adapter refuses to load sqlite3 2.x (it declares
gem "sqlite3", "~> 1.4"), so theactiverecord-7.0appraisal fails withcan't activate sqlite3 (~> 1.4), already activated sqlite3-2.9.6.To handle this, the sqlite3 requirement moves from the gemspec to the Gemfile. A gemspec dependency can't be overridden per appraisal, but a Gemfile entry can. The
activerecord-7.0appraisal now pinssqlite3 ~> 1.4, and everything else uses~> 2.9, >= 2.9.6.That means the AR 7.0 test run still uses sqlite3 1.7.x, which is affected by both advisories above. There is no patched 1.x release. This only affects that CI test job. Active Record 7.0 is end-of-life, so dropping that appraisal would remove the last vulnerable sqlite3 usage.
Testing
Both appraisals should pass: AR 7.0 resolves sqlite3 1.7.x and AR 7.1 resolves 2.9.6.