Repository navigation
test(server-nestjs): stub every required env of the plugin module spec - #2883
Merged
Merged
Conversation
The spec stubbed 19 env vars but not DB_URL, nor the keycloak and observability variables required by their unconditionally enabled modules, so it only passed where a local .env provided them. Stub the full required set so the test passes without a .env. Refs #2882 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I829cedfe41997cb5297d5e651efc2eb96a6a6964
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (62.20% Estimated after merge)
StephaneTrebel
approved these changes
Oct 21, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
No findings. Les dix variables ajoutées couvrent les configurations requises : après neutralisation des valeurs externes chargées par le client Prisma partagé, le test initial échoue sur DB_URL alors que celui de cette tête passe ; le lint ciblé et la CI sont verts. Ledger #2882 : 2/2 critères démontrés, sans modification des cases ; #2796 touche également ce test et #2861 en déplace le chemin.
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pourquoi
plugin.module.spec.tsn'est pas hermétique : il stubbe 19 variables d'environnement mais pasDB_URL, ni les variables requises par les modules Keycloak et observabilité, activés inconditionnellement. En l'absence d'un.envlocal fournissant ces valeurs, le test échoue avecZodError: DB_URL Required. Refs #2882Quoi
DB_URL, les 7 variables Keycloak requises,GRAFANA_URLetDSO_OBSERVABILITY_CHART_VERSION..env.Références
core/plugin/)