Repository navigation
Improper charset handling in CloudEvents::HttpBinding#decode_event #109
Description
Activity
Thanks for the report. I'm looking into this now.
Reacted by DominikYou're correct, the
CloudEvents::ContentTypeclass incorrectly defaults tous-asciifor all content types, even though some types, like JSON, expectutf-8. It looks likeus-asciiis still an appropriate default fortext/plain, especially in the case where the content type is not specified, but most text-based content types, including JSON, probably expectutf-8, so I'm adjusting the logic accordingly: #111Awesome! Thanks for the quick reaction.
cloud_events 0.8.3 released with the fix.
Metadata
Metadata
Assignees
Labels
No labels
CloudEvents::HttpBinding#decode_eventinstantiates aCloudEvents::ContentTypeinstance, which default to a charset ofus-ascii. Next, it enforces that default charset onto the input string. Unfortunately, there seems to be no way to set the charset explicitly.This lets the JSON parser crash when the input string contains non-ASCII characters (e.g. a German
ä) injsonversions 2.8 and above (2.18 checked).json2.7 is less strict on encoding and does not crash.Please check and confirm this issue. I'll be happy to prepare a PR.