Repository navigation
Conversation
RAnders00
force-pushed
the
patch-1
branch
2 times, most recently
from
October 6, 2026 18:21
c7165ad to
bb74689
Compare
Collaborator
|
ping @ColinSullivan1 |
RAnders00
force-pushed
the
patch-1
branch
3 times, most recently
from
October 7, 2026 07:56
721b488 to
e9fb879
Compare
Fixes cloudevents#1398 Signed-off-by: Ruben Anders <ruben.anders@robotty.de>
Collaborator
|
@RAnders00 thanks for this. Am I correct that if we were to focus on "just the real concern", it's the lack of the word "prefixed" in the NATS section? The rest of it looks like editorial tweaks. Is that correct? I'm not against editorial tweaks, but I want to make sure we have a clear distinction of "must" vs "nice to have" fixes since the group is trying to minimize changes to the CE specs. |
Author
|
@duglin Yeah, I think the NATS section needs amending. The other changes are, as you said, editorial tweaks because I looked more into this area and figured these things could be clarified. Apologies if that's uncalled for, I can undo those changes. |
Collaborator
|
No the changes are fine - I just wanted to make sure I wasn't missing something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1398
Proposed Changes
application/cloudevents, one could understand that to includeapplication/cloudevents-batch, which would clearly be incorrect.Release Note
No release note is needed, since this detection was not part of v1.0.2.