Repository navigation
Conversation
…implementation Some published vectors didn't match the reference implementation, and some couldn't be reproduced from the event JSON printed next to them: - Cases 1 and 2 carried an outdated payload, a bare digest instead of the JSON material body. - Cases 6a and 6b were corrupted and their signatures didn't verify against the test key. - Cases 1-5 printed their events with different indentation from the events that were signed. Whitespace inside `data` is part of the signed bytes, so the digests didn't match the events shown. Every vector is now the reference implementation's expected value, and Cases 1-5 print their events exactly as its test fixtures, so signing each printed event reproduces its vector. The HTTP examples are made consistent too: the structured-mode examples use the Case 1 event so the signed one carries Case 1's material, the binary-mode example is signed over its body as shown, and each Content-Length matches its body. Signed-off-by: xibz <bjp@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1386. Some of the verifiability extension's published test vectors didn't match the reference implementation, and some couldn't be reproduced from the event JSON printed next to them, so implementations couldn't pass them as written.
Proposed Changes
datais part of the signed bytes, so the digests didn't match the events shown.Content-Lengthmatches its body.No normative text changes. Only the example values are updated.
Release Note