Repository navigation
Spec data copy schemas for #82 - #103
Open
shipmill-romamo[bot] wants to merge 1 commit into
Open
shipmill-romamo[bot] wants to merge 1 commit into
shipmill-romamo[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@romamo Decision needed: do you approve this spec as written? Merging a spec is its approval (the spec gate), so shipmill holds it for your review instead of merging it on green CI.
Reply here with a number or your own answer; shipmill takes this up on the tick after your reply. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec for #82:
docs/specs/007-data-copy-schemas.md, choosing which schemascloudfall data copytakes and refusing before a dump that can't restore.--schemaflag ondata copy(and--data-schema DATABASE=NAMEoncloudfall migrate), since a copy is configured by flags today and theServicedeclares only the targetpg_dumpdumps today; narrowing topublicwould silently drop schemas existing migrations copy. The empty-target and row-count checks now cover exactly the selected schemasanon,authenticated) andauth.references, all in onePRECONDITIONrefusal before anything is dumpedpg_restore --single-transactionso a failed restore leaves the target empty; the receipt gainsspec.schemasand aschemaper table (additive)Merging this PR approves the spec.
🤖 Generated with Claude Code