Repository navigation
fix: migrate resolves --env-file and --data paths against the project - #12
Merged
Merged
Conversation
The argparse CLI ran migrate inside the project directory, so a relative env file or source URL file meant one there. The treaty port resolved them against the current directory instead. Found rewriting the LedgrAI deployment runbook for the new CLI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015MJdwagp7FxuuxminHgv2V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrate --env-file NAME=PATHand--data NAME=PATHresolve a relative path against the project again. The argparse CLI ranmigrateinside the project directory, so that is what a relative path meant; the treaty port (#6 to #11) resolved these two against the current directory, unlike every other path flag.Found rewriting the LedgrAI deployment runbook for the new CLI.
Checks
test_migrate_resolves_env_and_data_files_against_the_projectfails without the fixuv run pytest: 458 passed; ruff, mypy clean🤖 Generated with Claude Code
https://claude.ai/code/session_015MJdwagp7FxuuxminHgv2V