Repository navigation
treaty rc18: cleanup fix, reports and snapshots kept as output - #13
Merged
Merged
Conversation
rc18 fixes treaty #227, where cleanup --confirm-destructive could delete
paths it should keep, such as a declared path spelled in another case on
macOS. Cloudfall declares side effects under {project_root}/tmp/ since
rc13, so its cleanup was exposed.
The dashboard, the domain observations and observe's server snapshots are
now SideEffect "output" (rc17): cleanup never removes them, which matters
for the snapshots audit reads. Only the regenerated inventory overlay
stays "cache".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015MJdwagp7FxuuxminHgv2V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps treaty from 1.0.0rc14 to 1.0.0rc18.
Why now
rc18 fixes treaty #227: on rc17 and earlier,
cleanup --confirm-destructivecould delete paths it should keep, including a declared path spelled in another case on macOS, and in one case the whole project. Cloudfall has declared side effects under{project_root}/tmp/since rc13, socloudfall cleanupwas exposed.Changes
dashboard build(tmp/dashboard/),services inspect(tmp/observed-services/) andobserve(tmp/observed/) declare those directories asSideEffect(..., "output")(rc17):cleanupnever removes them. The snapshots matter most, sinceauditreads them.observe's inventory overlay (tmp/cloudfall/) stayscacheApp.call, rc18idempotent=Trueon any danger level)Checks
uv run pytest: 458 passed; ruff, mypy cleantreaty audit --stricton both apps: no warningscloudfall cleanuppreview on a copy of the example project with snapshots, a dashboard and an overlay: onlytmp/cloudfallwould be removed, from the normal path and from a differently cased one (/users/roman/pycharmprojects/...)🤖 Generated with Claude Code
https://claude.ai/code/session_015MJdwagp7FxuuxminHgv2V