Repository navigation
Supersede a proposal only by one of the same replay value - #60
Merged
Merged
Conversation
A replay never closes a live proposal and a live run never closes a replayed one. A replayed read stays ran, but its verdict and cloudfall why say its output was played back from the recording, not run on the hosts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
propose()now supersedes an olderproposedrecord only when it has the samereplayvalue as the new decision, besides the same operation, targets and inputs (D-7). Live closes live, a replay closes a replay of the same recording, and nothing crosses between them. Replays of two different recordings don't supersede each other, because the check is plain equality of the field.Decision.same_call()is unchanged. Its only caller is the supersede loop inpropose(), and the replay check is added there.ranand its exit code. Its verdict now reads "a read operation's output was played back from the recording X, not run on the hosts; it exited N".cloudfall whykeeps its existing replay sentence. Its closing line for a replayed read no longer says "It ran when it was proposed"; it says "Its played-back output exited N: a read operation waits for no approval."Tests
test_only_a_proposal_of_the_same_replay_value_supersedescovers 5 cases: live then live, live then replay, replay then live, the same replay twice, and two different replays.test_a_replayed_read_says_its_output_was_played_back,test_a_live_read_keeps_its_verdictandtest_a_replayed_read_is_not_told_as_run_on_the_hosts(why).test_a_replayed_decision_since_superseded_is_refused_as_replayednow supersedes the replayed record with a second replay of the same recording. Under D-7 a live proposal no longer closes it.uv run ruff check .,uv run mypy, the fulluv run pytest(474 passed) anduv run cloudfall config validate --project config/examples.Fixes #58
🤖 Generated with Claude Code