Repository navigation
Spec domain routes for #90 - #99
Open
shipmill-romamo[bot] wants to merge 1 commit into
Open
shipmill-romamo[bot] wants to merge 1 commit into
shipmill-romamo[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Before merging this: its rule "exactly one of |
Contributor
Author
|
@romamo Decision needed: do you approve this spec, once its "exactly one of
Reply here with a number or your own answer; shipmill takes this up on the tick after your reply. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec for #90
spec.routes: each a proxy route (upstream: {address, port}, full request path kept) or a static route serving<installRoot>/current/<directory>of a component on the proxy server, with an optionalspaFallbackcurrentsymlink, so deploy andcloudfall rollbackswitch the served files with no nginx reloadcloudfall config validaterequires exactly one ofproxy.upstreamorroutes, and refuses duplicate, reserved (/.well-known/acme-challenge) or unsafe paths, static paths without a trailing/, and components not deployed on the proxy serverproxy.upstreamrenders a byte-identical vhosthealthCheckstays per Domainuv sync#86), which puts the frontend build in the artifact🤖 Generated with Claude Code