Skip to content

chore: update OpenAPI to 1ba4440f11a6 - #403

Open
ant-release-bot wants to merge 1 commit into
mainfrom
automation/update-forge
Open

ant-release-bot wants to merge 1 commit into
mainfrom
automation/update-forge

Conversation

@ant-release-bot

@ant-release-bot ant-release-bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Updates cf to openapi@1ba4440f11a6cf65410c05e4c4395ad456fbff91.

  • pins OpenAPI revision 1ba4440f11a6cf65410c05e4c4395ad456fbff91
  • regenerates the committed command surface with the pinned Forge package

This PR is maintained automatically by the Update OpenAPI workflow.

@ant-release-bot
ant-release-bot requested a review from a team as a code owner October 23, 2026 18:40
@ask-bonk

ask-bonk Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@clanky-the-clanker

clanky-the-clanker Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

💬 Approved with comments — The regenerated output is consistent and nothing blocks merging. The only comment is an optional suggestion to name the new user-facing commands and flags in the changeset.

Findings: 1 suggestion

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.

🔧 Fix with your agent

Paste the following into your coding agent to investigate and fix these issues.

Fix the following code review issues found in pull request #403.

Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
  for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

## SUGGESTION (1)

### [Release] The changeset body does not name the user-facing additions (the new `aggregate-severity` command, the `--product` flag on `casb findings export`, and the healthchecks commands that are now visible). Consider summarizing them, ideally in the update workflow's template.
- **File:** .changeset/update-openapi-1ba4440f11a6.md:5

🚀 Release: 💬 1 suggestion

The changeset does not name the user-facing additions

Recommendation: 💬 Optional Nits

  • [SUGGESTION] The changeset body does not name the user-facing additions (the new aggregate-severity command, the --product flag on casb findings export, and the healthchecks commands that are now visible). Consider summarizing them, ideally in the update workflow's template. (.changeset/update-openapi-1ba4440f11a6.md:5)
View full review

Risk: Low

The changeset .changeset/update-openapi-1ba4440f11a6.md uses the correct minor bump. Its body only says that the generated command surface was updated. Users reading the changelog would find it more useful if the body listed the notable additions:

  • the new cloudforce-one threat-signals articles aggregate-severity command
  • the new --product filter on zero-trust casb findings export
  • the healthchecks commands, which are no longer hidden

This is optional. The changeset comes from automation, so any improvement would belong in the update workflow's template.


✅ All other checks passed

🔒 Security: ✅ LGTM

No security concerns in the regenerated commands or operation metadata.


📖 AGENTS.md: ✅ LGTM

The change follows the repository conventions. The generated output was regenerated rather than hand-edited, and a changeset is included for the user-facing change.


📋 Code Quality: ✅ LGTM

The regenerated output is internally consistent:

  • Pin and changeset: packages/cli/generate.ts pins revision 1ba4440f11a6…, and a minor changeset is present. minor is the right level because the update adds commands and flags.
  • New command: cloudforce-one threat-signals articles aggregate-severity has a matching _operations file and is registered in the articles/index.ts barrel.
  • New flag: the --product option on zero-trust casb findings export (SaaS / Cloud) is wired consistently into the option definition, the telemetry safeFlags list and both request-body paths.
  • CASB operations: the other CASB operation files only add a 429: "TooManyRequestsError" mapping.
  • Other edits: workers/versions/profile.ts changes only a description.
  • Healthchecks: _generated/index.ts:535 changes hideCommand from true to false for the healthchecks root. As a result, the healthchecks commands now show up in help. This comes from upstream metadata.

The generated files have the same shape as their neighbours, so there is no sign of hand-editing. This review did not inspect the full contents of _meta/commands.json and _meta/schemas.json.


⚡ Performance: ✅ LGTM

The changes are generated metadata and command wiring. The new command is still loaded lazily through the existing barrel, so there is no performance concern.


📝 Documentation: ✅ LGTM

No documentation issues.


Reviewed commit: 81d75b6e

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/cf@403

commit: 81d75b6

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

cf --help startup

mean stddev min max
PR 288.0 ms 3.7 ms 282.3 ms 295.6 ms
base 285.2 ms 4.9 ms 275.3 ms 295.1 ms

Δ (PR vs base): ↑ +2.8 ms (+1.0%)

Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 37b001d9ec1a chore: update OpenAPI to d5aad31a114e Oct 23, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from 7877d59 to b816740 Compare October 23, 2026 19:32
@ask-bonk

ask-bonk Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to d5aad31a114e chore: update OpenAPI to 5983a433f54f Oct 23, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from b816740 to 9bb7f89 Compare October 23, 2026 21:31
@ask-bonk

ask-bonk Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 5983a433f54f chore: update OpenAPI to 1ba4440f11a6 Oct 23, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from 9bb7f89 to 81d75b6 Compare October 23, 2026 22:31
@ask-bonk

ask-bonk Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant