[WAF] Enumerate Served by Cloudflare triggers in Security Analytics - #30204
Conversation
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
|
Hey there, we've closed out this pull request because it's been stale for a while and there's been no additional action on it. If these changes are still relevant, open a new pull request (or flag to us in a GitHub issue). |
Pull request was closed
Review
👉 Fix in your agent 👈Fix the following review findings in PR #30204 (https://github.com/cloudflare/cloudflare-docs/pull/30204).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Conventions
### Warnings (2)
#### CV-c68116ad5c62 · PR description
- **File:** PR-level finding
- **Issue:** The description is only "Tracked by DEE-2812." and provides no explanation of what the PR does.
- **Fix:** Add a sentence describing the change, such as which "Served by Cloudflare" triggers are enumerated in Security Analytics.
#### CV-46fcb69b43c1 · PR description omits core changes
- **File:** PR-level finding
- **Issue:** The description does not mention any of the PR's changes; the PR also edits cache/performance-review/cache-analytics.mdx (+5) and fundamentals/reference/cdn-cgi-endpoint.mdx (+4), which are not covered by the title's WAF scope.
- **Fix:** Describe the full scope of the PR, including the changes to the cache analytics and cdn-cgi endpoint documentation.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsWarnings (2)
Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Expand the Served by Cloudflare classification definition in Security Analytics to list all four triggers: cache hits, URL forwarding redirects, /cdn-cgi/ endpoints, and Workers responses. Previously the doc only mentioned 'cached content and redirects'. Align the Cache Analytics page with a cross-reference to the canonical definition in Security Analytics. Add a note on the /cdn-cgi/ endpoint page clarifying that /cdn-cgi/ traffic is classified as Served by Cloudflare in Security Analytics. Tracked by SPM-2812.
Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com>
88f0dd5 to
e5350c5
Compare
|
Hey there, we've closed out this pull request because it's been stale for a while and there's been no additional action on it. If these changes are still relevant, open a new pull request (or flag to us in a GitHub issue). |
Pull request was closed
|
/rebase |
|
@Oxyjun @elithrar @AdamBouhmad @zaidoon1 @ack-cf @mbullock1986 @KaydeeDee @xmflsct @danielegm - could you please review this PR? Thanks. |
|
/rebase |
|
Rebase failing - created a new PR: #33032 |
Tracked by DEE-2812.