Repository navigation
chore(docs): upgrade the docs site to Nimbus 0.19.0 - #68
Draft
MohamedH1998 wants to merge 1 commit into
Draft
MohamedH1998 wants to merge 1 commit into
MohamedH1998 wants to merge 1 commit into
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
cloudflare-api-sitefrom Nimbus 0.18 to 0.19.0. Nothing changes for readers. The build no longer emitsgetStaticPaths()warnings, and agent discovery files (llms.txt,.well-known/ard.json, sitemap) are served under/api.API pages are still drawn by
astro-fernandfern-forge; moving them to Nimbus is a separate change.Changes
@cloudflare/nimbus-docs^0.18.0→^0.19.0;nimbus.jsonrecords 0.19.0 as reviewed.rendering: { default: 'request' }(nimbus-docs check --fix):prerenderandgetStaticPathsexports removed from[...slug].astro,[...slug]/index.md.ts,[...slug]/index.mdx.tsandllms-full.txt.ts, with the stale comment and unused import that went with them.description-markdown.tsnow escapes only what Nimbus 0.19.0 still drops from descriptions used as text: HTML comments and<script>. Nimbus keepsmetadata.<key>-style placeholders itself, so the module no longer handles them and is renamedkeepDroppedHtml. Edge cases with no occurrence in the current spec now render as Nimbus does: a stray closing tag is dropped, and an unknown tag that opens an HTML block is no longer wrapped in<p>.astro-fern's copies ofastro/zodalready disagreed onmain; 0.19.0's type check surfaced it. No manifest outside the site changed.pnpm-workspace.yaml: pnpm's automaticminimumReleaseAgeExcludeentry for the new version.0.19.0 upgrade entries (17):
route-files-follow-renderingapplied. Optional and skipped:lighter-sidebar-rows,redesigned-starter,favicons-and-asset-caching,connect-mcp,agent-discovery-opt-out(the Worker owns its host),pnpm-sharp,collection-urls-from-routes. Not applicable:changelog-release-notes,og-font-path,branded-share-cards,search-provider-slices,api-home,api-code-rail-lines,api-sidebar-alignment,card-links,diagram-controls-height.Validation
Before and after builds used the same spec (
FORGE_OPENAPI_RELEASE=openapi@e2386f5f).Passed locally:
pnpm check,pnpm typecheck,pnpm test.pnpm test(134),astro check(0 errors),nimbus-docs check(all ok),nimbus-docs migratereports nothing pending,cf buildwith 0getStaticPaths()warnings (3 before),test:e2e(19),test:visual(28, against a baseline taken on 0.18).?lang=terraform), a command page,llms.txt, a 404./api/llms.txtresolves;/api/.well-known/ard.jsonand/api/sitemap-index.xmlserved.Pending: the deploy preview for this PR.
Pre-existing and unchanged:
nimbus-docs checknotes@astrojs/cloudflare@15.0.0-beta.2is newer than the version Nimbus declares support for.