Cache SharedSpan::is_sampled for deferred user tracing spans - #263
Merged
Conversation
fisherdarling
approved these changes
Sep 3, 2026
fisherdarling
requested changes
Sep 3, 2026
fisherdarling
left a comment
fisherdarling
left a comment
Collaborator
There was a problem hiding this comment.
didn't mean to stamp! whoops
fisherdarling
approved these changes
Sep 4, 2026
Relaxed atomic load and stores are just regular load and stores on x86 and arm64, so this adds zero cost for regular spans and allows us to avoid some more lock accesses for deferred user tracing spans.
TheJokr
force-pushed
the
lblocher/span-sampled-mut
branch
from
September 4, 2026 17:24
dd045e2 to
3fd770e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaxed atomic load and stores are just regular load and stores on x86 and arm64, so this adds zero cost for regular spans and allows us to avoid some more lock accesses for deferred user tracing spans.