Skip to content

Use HEAD instead of last commit for getting final content - #1972

Merged
prymitive merged 1 commit into
mainfrom
issue-1943
Sep 9, 2026
Merged

Use HEAD instead of last commit for getting final content#1972
prymitive merged 1 commit into
mainfrom
issue-1943

Conversation

@prymitive

Copy link
Copy Markdown
Collaborator

Fixes #1943.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

❗ Problems found.

Severity Number of problems
Information 5
Stats

Stat Value
Version v0.87.0-96-ga1c5c6fe
Number of rules parsed 22
Number of rules checked 22
Number of problems found 5
Number of offline checks 5
Number of online checks 0
Checks duration 6ms

Problems

Information: problem reported by config rule (rule/report)
  ---> .github/pint/rules/reject.yml:4-10 -> `Bad Label Key` [+4 duplicates]
4 |   - alert: Bad Label Key
               ^^^^^^^^^^^^^ Rules in this file are intentionally broken for testing.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (02fa7ee) to head (a1c5c6f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1972   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines        13851     13850    -1     
=========================================
- Hits         13851     13850    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: INTEL(R) XEON(R) PLATINUM 8573C
                             │   old.txt    │              new.txt               │
                             │    sec/op    │    sec/op     vs base              │
GlobFinder                     34.64m ± ∞ ¹   34.62m ± ∞ ¹       ~ (p=0.589 n=6)
GitFinder                      430.5m ± ∞ ¹   428.6m ± ∞ ¹       ~ (p=0.589 n=6)
Check/promql/counter           2.851m ± ∞ ¹   2.854m ± ∞ ¹       ~ (p=0.589 n=6)
Check/alerts/absent            64.68µ ± ∞ ¹   64.84µ ± ∞ ¹       ~ (p=0.699 n=6)
Check/alerts/count             12.29m ± ∞ ¹   12.60m ± ∞ ¹       ~ (p=0.394 n=6)
Check/promql/syntax            19.63µ ± ∞ ¹   19.69µ ± ∞ ¹  +0.32% (p=0.041 n=6)
Check/alerts/for               136.6µ ± ∞ ¹   138.2µ ± ∞ ¹       ~ (p=0.132 n=6)
Check/rule/dependency          18.65m ± ∞ ¹   18.38m ± ∞ ¹  -1.44% (p=0.004 n=6)
Check/promql/nan               1.797m ± ∞ ¹   1.805m ± ∞ ¹  +0.45% (p=0.015 n=6)
Check/promql/series             1.028 ± ∞ ¹    1.089 ± ∞ ¹       ~ (p=0.093 n=6)
Check/promql/vector_matching   17.16m ± ∞ ¹   17.54m ± ∞ ¹  +2.21% (p=0.009 n=6)
Check/promql/offset            2.804m ± ∞ ¹   2.914m ± ∞ ¹  +3.94% (p=0.002 n=6)
Check/rule/reject              118.9µ ± ∞ ¹   117.7µ ± ∞ ¹  -0.99% (p=0.002 n=6)
Check/alerts/template          218.6m ± ∞ ¹   225.2m ± ∞ ¹  +3.02% (p=0.026 n=6)
Check/group/interval           3.259µ ± ∞ ¹   3.245µ ± ∞ ¹  -0.41% (p=0.045 n=6)
Check/promql/rate              4.394m ± ∞ ¹   4.472m ± ∞ ¹  +1.77% (p=0.002 n=6)
Check/alerts/annotation        543.3µ ± ∞ ¹   545.9µ ± ∞ ¹  +0.47% (p=0.002 n=6)
Check/query/cost               22.30m ± ∞ ¹   22.61m ± ∞ ¹       ~ (p=0.240 n=6)
Check/promql/fragile           86.33µ ± ∞ ¹   88.90µ ± ∞ ¹       ~ (p=0.180 n=6)
Check/promql/impossible        83.34µ ± ∞ ¹   84.94µ ± ∞ ¹  +1.91% (p=0.002 n=6)
Check/promql/range_query       2.934m ± ∞ ¹   2.973m ± ∞ ¹  +1.32% (p=0.041 n=6)
Check/promql/features          82.57µ ± ∞ ¹   82.81µ ± ∞ ¹       ~ (p=0.240 n=6)
Check/rule/label               1.579m ± ∞ ¹   1.516m ± ∞ ¹  -3.95% (p=0.004 n=6)
Check/alerts/comparison        40.21µ ± ∞ ¹   40.11µ ± ∞ ¹       ~ (p=0.093 n=6)
Check/promql/regexp            1.453m ± ∞ ¹   1.514m ± ∞ ¹  +4.17% (p=0.002 n=6)
Check/rule/duplicate           22.15m ± ∞ ¹   22.22m ± ∞ ¹  +0.33% (p=0.015 n=6)
Check/labels/conflict          2.014m ± ∞ ¹   2.046m ± ∞ ¹  +1.57% (p=0.002 n=6)
Check/alerts/external_labels   43.36m ± ∞ ¹   44.07m ± ∞ ¹  +1.64% (p=0.026 n=6)
RuleIsIdentical                12.70m ± ∞ ¹   12.74m ± ∞ ¹       ~ (p=0.065 n=6)
GetChecksForEntry              211.4m ± ∞ ¹   207.5m ± ∞ ¹       ~ (p=0.093 n=6)
geomean                        2.465m         2.488m        +0.94%
¹ need >= 8 samples for confidence interval at level 0.99

                             │    old.txt    │                new.txt                │
                             │     B/op      │     B/op       vs base                │
GlobFinder                     12.77Mi ± ∞ ¹   12.77Mi ± ∞ ¹       ~ (p=0.331 n=6)
GitFinder                      25.94Mi ± ∞ ¹   25.93Mi ± ∞ ¹       ~ (p=0.132 n=6)
Check/promql/counter           455.1Ki ± ∞ ¹   455.1Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/absent            3.812Ki ± ∞ ¹   3.812Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/count             1.466Mi ± ∞ ¹   1.465Mi ± ∞ ¹       ~ (p=0.485 n=6)
Check/promql/syntax              0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/for               88.41Ki ± ∞ ¹   88.41Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/rule/dependency          15.90Mi ± ∞ ¹   15.90Mi ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/nan               191.6Ki ± ∞ ¹   191.6Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/series            98.53Mi ± ∞ ¹   98.53Mi ± ∞ ¹       ~ (p=0.688 n=6)
Check/promql/vector_matching   8.204Mi ± ∞ ¹   8.204Mi ± ∞ ¹       ~ (p=0.589 n=6)
Check/promql/offset            418.5Ki ± ∞ ¹   418.5Ki ± ∞ ¹  +0.00% (p=0.002 n=6)
Check/rule/reject                0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/template          113.1Mi ± ∞ ¹   113.1Mi ± ∞ ¹  +0.00% (p=0.002 n=6)
Check/group/interval             0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/rate              379.1Ki ± ∞ ¹   379.1Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/annotation          0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/query/cost               525.0Ki ± ∞ ¹   525.0Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/fragile           15.50Ki ± ∞ ¹   15.50Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/impossible          704.0 ± ∞ ¹     704.0 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/range_query       418.0Ki ± ∞ ¹   418.0Ki ± ∞ ¹  +0.00% (p=0.009 n=6)
Check/promql/features            0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/rule/label               685.7Ki ± ∞ ¹   685.7Ki ± ∞ ¹  +0.00% (p=0.002 n=6)
Check/alerts/comparison          352.0 ± ∞ ¹     352.0 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/regexp            477.6Ki ± ∞ ¹   477.6Ki ± ∞ ¹  +0.00% (p=0.013 n=6)
Check/rule/duplicate             0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/labels/conflict          275.8Ki ± ∞ ¹   275.8Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/external_labels   18.67Mi ± ∞ ¹   18.67Mi ± ∞ ¹  +0.00% (p=0.002 n=6)
RuleIsIdentical                  0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
GetChecksForEntry              100.1Mi ± ∞ ¹   100.1Mi ± ∞ ¹       ~ (p=0.167 n=6)
geomean                                    ³                  -0.00%               ³
¹ need >= 8 samples for confidence interval at level 0.99
² all samples are equal
³ summaries must be >0 to compute geomean

                             │   old.txt    │               new.txt                │
                             │  allocs/op   │  allocs/op    vs base                │
GlobFinder                     197.8k ± ∞ ¹   197.8k ± ∞ ¹       ~ (p=0.182 n=6)
GitFinder                      244.4k ± ∞ ¹   244.4k ± ∞ ¹       ~ (p=0.602 n=6)
Check/promql/counter           24.14k ± ∞ ¹   24.14k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/absent             76.00 ± ∞ ¹    76.00 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/count             33.57k ± ∞ ¹   33.57k ± ∞ ¹       ~ (p=1.000 n=6)
Check/promql/syntax             0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/for               1.476k ± ∞ ¹   1.476k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/rule/dependency          7.632k ± ∞ ¹   7.632k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/nan               3.652k ± ∞ ¹   3.652k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/series            1.418M ± ∞ ¹   1.418M ± ∞ ¹       ~ (p=1.000 n=6)
Check/promql/vector_matching   92.03k ± ∞ ¹   92.03k ± ∞ ¹       ~ (p=0.058 n=6)
Check/promql/offset            12.42k ± ∞ ¹   12.42k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/rule/reject               0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/template          1.046M ± ∞ ¹   1.046M ± ∞ ¹  +0.00% (p=0.002 n=6)
Check/group/interval            0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/rate              8.202k ± ∞ ¹   8.202k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/annotation         0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/query/cost               7.624k ± ∞ ¹   7.624k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/fragile            246.0 ± ∞ ¹    246.0 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/impossible         5.000 ± ∞ ¹    5.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/range_query       12.41k ± ∞ ¹   12.41k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/features           0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/rule/label               11.45k ± ∞ ¹   11.45k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/comparison         4.000 ± ∞ ¹    4.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/promql/regexp            8.587k ± ∞ ¹   8.587k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/rule/duplicate            0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/labels/conflict          5.724k ± ∞ ¹   5.724k ± ∞ ¹       ~ (p=1.000 n=6) ²
Check/alerts/external_labels   321.8k ± ∞ ¹   321.8k ± ∞ ¹  +0.00% (p=0.002 n=6)
RuleIsIdentical                 0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=6) ²
GetChecksForEntry              1.645M ± ∞ ¹   1.645M ± ∞ ¹       ~ (p=0.273 n=6)
geomean                                   ³                 +0.00%               ³
¹ need >= 8 samples for confidence interval at level 0.99
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/diags
                           │   old.txt    │              new.txt               │
                           │    sec/op    │    sec/op     vs base              │
InjectDiagnosticsLongExpr    7.964µ ± ∞ ¹   7.966µ ± ∞ ¹       ~ (p=0.916 n=6)
InjectDiagnosticsShortExpr   1.127µ ± ∞ ¹   1.129µ ± ∞ ¹  +0.13% (p=0.041 n=6)
geomean                      2.996µ         2.998µ        +0.08%
¹ need >= 8 samples for confidence interval at level 0.99

                           │    old.txt    │                new.txt                │
                           │     B/op      │     B/op       vs base                │
InjectDiagnosticsLongExpr    3.578Ki ± ∞ ¹   3.578Ki ± ∞ ¹       ~ (p=1.000 n=6) ²
InjectDiagnosticsShortExpr     304.0 ± ∞ ¹     304.0 ± ∞ ¹       ~ (p=1.000 n=6) ²
geomean                      1.031Ki         1.031Ki        +0.00%
¹ need >= 8 samples for confidence interval at level 0.99
² all samples are equal

                           │   old.txt   │               new.txt               │
                           │  allocs/op  │  allocs/op   vs base                │
InjectDiagnosticsLongExpr    39.00 ± ∞ ¹   39.00 ± ∞ ¹       ~ (p=1.000 n=6) ²
InjectDiagnosticsShortExpr   13.00 ± ∞ ¹   13.00 ± ∞ ¹       ~ (p=1.000 n=6) ²
geomean                      22.52         22.52        +0.00%
¹ need >= 8 samples for confidence interval at level 0.99
² all samples are equal

pkg: github.com/cloudflare/pint/internal/parser
      │   old.txt    │              new.txt               │
      │    sec/op    │    sec/op     vs base              │
Parse   17.13m ± ∞ ¹   17.01m ± ∞ ¹  -0.72% (p=0.041 n=6)
¹ need >= 8 samples for confidence interval at level 0.99

      │    old.txt    │            new.txt             │
      │     B/op      │     B/op       vs base         │
Parse   6.385Mi ± ∞ ¹   6.385Mi ± ∞ ¹  ~ (p=0.818 n=6)
¹ need >= 8 samples for confidence interval at level 0.99

      │   old.txt    │            new.txt            │
      │  allocs/op   │  allocs/op    vs base         │
Parse   102.8k ± ∞ ¹   102.8k ± ∞ ¹  ~ (p=0.545 n=6)
¹ need >= 8 samples for confidence interval at level 0.99

pkg: github.com/cloudflare/pint/internal/parser/source
             │   old.txt    │            new.txt            │
             │    sec/op    │    sec/op     vs base         │
LabelsSource   1.088m ± ∞ ¹   1.083m ± ∞ ¹  ~ (p=0.093 n=6)
¹ need >= 8 samples for confidence interval at level 0.99

             │    old.txt    │            new.txt             │
             │     B/op      │     B/op       vs base         │
LabelsSource   753.9Ki ± ∞ ¹   753.9Ki ± ∞ ¹  ~ (p=0.331 n=6)
¹ need >= 8 samples for confidence interval at level 0.99

             │   old.txt    │             new.txt             │
             │  allocs/op   │  allocs/op    vs base           │
LabelsSource   7.370k ± ∞ ¹   7.370k ± ∞ ¹  ~ (p=1.000 n=6) ²
¹ need >= 8 samples for confidence interval at level 0.99
² all samples are equal

pkg: github.com/cloudflare/pint/internal/promapi
                  │   old.txt    │            new.txt            │
                  │    sec/op    │    sec/op     vs base         │
QueryCacheOnlySet   112.7n ± ∞ ¹   112.2n ± ∞ ¹  ~ (p=0.377 n=6)
¹ need >= 8 samples for confidence interval at level 0.99

                  │   old.txt   │            new.txt             │
                  │    B/op     │    B/op      vs base           │
QueryCacheOnlySet   64.00 ± ∞ ¹   64.00 ± ∞ ¹  ~ (p=1.000 n=6) ²
¹ need >= 8 samples for confidence interval at level 0.99
² all samples are equal

                  │   old.txt   │            new.txt             │
                  │  allocs/op  │  allocs/op   vs base           │
QueryCacheOnlySet   1.000 ± ∞ ¹   1.000 ± ∞ ¹  ~ (p=1.000 n=6) ²
¹ need >= 8 samples for confidence interval at level 0.99
² all samples are equal

@prymitive
prymitive merged commit e01f4b4 into main Sep 9, 2026
20 checks passed
@prymitive
prymitive deleted the issue-1943 branch September 9, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pint ci will attempt and fail to comment on a file modified in commit history but not in the final branch iteration

2 participants