Python: Patch workers.wait_until as well as ctx.waitUntil - #7293
Merged
Conversation
|
The generated output of |
hoodmane
force-pushed
the
hoodmane/patch-workers-waitUntil
branch
from
September 9, 2026 17:36
a86e182 to
0fc5660
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Patches module-level Python
|
ryanking13
approved these changes
Sep 10, 2026
ryanking13
left a comment
ryanking13
left a comment
Contributor
There was a problem hiding this comment.
Thanks! In the future, I would like to move these kinds of wrappers into workers-py, but for now looks good.
hoodmane
force-pushed
the
hoodmane/patch-workers-waitUntil
branch
from
September 10, 2026 05:13
e00d7ca to
21abee7
Compare
We've been patching `ctx.waitUntil()` so that when it is passed a Python awaitable it will keep it alive until it resolves. We forgot to patch `workers.wait_until()` in the same way. This fixes the problem. Thanks to audreyfeldroy for reporting this in cloudflare/workers-py # 249.
hoodmane
force-pushed
the
hoodmane/patch-workers-waitUntil
branch
from
September 10, 2026 18:48
21abee7 to
e23e55d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been patching
ctx.waitUntil()so that when it is passed a Python awaitable it will keep it alive until it resolves. We forgot to patchworkers.wait_until()in the same way. This fixes the problem.Thanks to @audreyfeldroy for reporting this in cloudflare/workers-py#249.