Skip to content

fix(runtime-sdk): fix top-level entropy call for litestar and fix entropy tests - #241

Merged
ryanking13 merged 8 commits into
mainfrom
gyeongjae/broken-entropy-test
Sep 8, 2026
Merged

fix(runtime-sdk): fix top-level entropy call for litestar and fix entropy tests#241
ryanking13 merged 8 commits into
mainfrom
gyeongjae/broken-entropy-test

Conversation

@ryanking13

Copy link
Copy Markdown
Contributor

It turned out entropy tests were not properly working. Since test files were not picked up during the worker initialization, they were not included during the snapshot creation and was failing to detect entropy errors.

@ryanking13
ryanking13 marked this pull request as draft August 31, 2026 09:16
Comment thread packages/runtime-sdk/tests/workerd-test/entropy-patches/worker.py
@ask-bonk

ask-bonk Bot commented Aug 31, 2026

Copy link
Copy Markdown

I'm Bonk, and I've done a quick review of your PR.

This moves entropy-import checks into snapshot-time module imports.

  1. P1: Posted one suggestion to restore missing NumPy entropy-patch coverage.

github run

@ryanking13 ryanking13 changed the title DRAFT fix(runtime-sdk): fix broken entropy patches fix(runtime-sdk): fix top-level entropy call for litestar and fix entropy tests Sep 7, 2026
@ryanking13
ryanking13 marked this pull request as ready for review September 7, 2026 05:20
Comment thread packages/runtime-sdk/tests/test_in_workerd.py
@ryanking13

Copy link
Copy Markdown
Contributor Author

Merging so we can put more changes on top of this. 3.14 is still not working and some packages are found to be broken.

@ryanking13
ryanking13 merged commit 99b77c7 into main Sep 8, 2026
19 checks passed
@ryanking13
ryanking13 deleted the gyeongjae/broken-entropy-test branch September 8, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants