chore: Remove django lint-ignore raise inside except with no from - #254
Open
hoodmane wants to merge 1 commit into
Open
chore: Remove django lint-ignore raise inside except with no from#254hoodmane wants to merge 1 commit into
hoodmane wants to merge 1 commit into
Conversation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
|
I'm Bonk, and I've done a quick review of your PR. Removes obsolete Django exception wrappers and eager/lazy
|
hoodmane
commented
Sep 10, 2026
| from django.core.files.storage import Storage | ||
| from django.utils.deconstruct import deconstructible | ||
| from js import Uint8Array | ||
| from pyodide.ffi import run_sync |
Contributor
Author
There was a problem hiding this comment.
There shouldn't be any case where from js import Uint8Array works but from pyodide.ffi import run_sync does not, so the guard before was pointless.
hoodmane
commented
Sep 10, 2026
Comment on lines
+10
to
+16
| try: | ||
| from pyodide.ffi import run_sync | ||
| except ImportError: | ||
|
|
||
| def run_sync(a): | ||
| raise RuntimeError("Code not running inside a worker!") | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Probably pointless to guard it like this since the other file just assumes we're in Pyodide.
Contributor
There was a problem hiding this comment.
Yeah, I guess we can just remove this guard. There was some host-side tests that were not running in workers before, but I cleaned them up.
And clean up some debug code that I noticed from the lints.
hoodmane
force-pushed
the
hoodmane/remove-one-django-lint-ignore
branch
from
September 10, 2026 19:29
96af9c3 to
f1d26f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And clean up some debug code that I noticed from the lints.