Repository navigation
Conversation
|
@ajth-in is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #141
This is an optimization that reduces the published
distoutput by ~1.37 KB (~480 B gzip) by no longer bundling the entireastro-cloudinary/package.jsonjust to read the version number used for analytics.getCloudinaryAnalyticsinastro-cloudinary/src/lib/cloudinary.ts:38attaches SDK/tech versions to every generated Cloudinary URL:Those constants come from
astro-cloudinary/src/constants/analytics.ts, which imported both:astro/package.json(the peer dependency), and../../package.json(this package).The second import inlined the entire
astro-cloudinary/package.jsonmanifest as a JS object inside the shared tsup chunk (dist/chunk-*.js), which is imported by bothdist/helpers/index.jsanddist/loaders/index.js.Changes
import pkg from '../../package.json'with a build-time constant,__ASTRO_CLOUDINARY_VERSION__, injected via tsup'sdefineoption. Only the version string is now emitted instead of the whole manifest (including scripts, devDependencies, repository, etc.).Result
The shared analytics chunk before and after the change:
dist/chunk-M4MK3WLV.js(full manifest inlined)dist/chunk-STN24IAD.js(version string only)Total
distoutput drops from ~11.64 KB to ~10.28 KB.Type of change
Checklist