Skip to content

Fix: don't force non-crop size slugs to exact dimensions #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
airbuzz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: don't force non-crop size slugs to exact dimensions #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions php/class-media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3301,6 +3301,16 @@ public function get_size_from_slug( $size_slug ) {

$size_data = $image_subsizes[ $size_slug ];

// A non-crop ( crop => false ) size is a maximum bounding box, not exact dimensions.
// WordPress scales such images to fit inside the box while preserving the aspect ratio,
// so the registered width/height must not be treated as a fixed crop. Doing so forces
// non-square images into the box dimensions ( e.g. the default `large` 1024x1024 becomes
// w_1024,h_1024,c_scale ), visibly stretching landscape/portrait assets. Only hard-crop
// sizes have exact dimensions worth pinning here.
if ( empty( $size_data['crop'] ) ) {
return null;
}

// Return width and height if both are present and valid.
if ( ! empty( $size_data['width'] ) && ! empty( $size_data['height'] ) ) {
return array( (int) $size_data['width'], (int) $size_data['height'] );
Expand Down