Skip to content

fix(ui): fix rules of hooks violations via useId #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
franzheidl wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(ui): fix rules of hooks violations via useId #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a92dc48
fix(ui): fix rules of hooks violations with useId
franzheidl Aug 7, 2026
104ca4e
Merge branch 'main' into franz-fix-rules-of-hooks-1589
franzheidl Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/ui-components/src/components/CheckboxGroup/CheckboxGroup.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,12 @@ export const CheckboxGroup = ({
return !(typeof str === "string" && str.trim().length === 0)
}

const uniqueId = () => "juno-checkboxgroup-" + useId()
const generatedName = useId()
const generatedId = useId()

// Create unique identifiers for use with name and id of the group:
const groupName = name || uniqueId()
const groupId = id || uniqueId()
const groupName = name || "juno-checkboxgroup-" + generatedName
const groupId = id || "juno-checkboxgroup-" + generatedId

// Init state variables:
const [selectedOptions, setSelectedOptions] = useState<string[] | undefined>(selected)
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-components/src/components/ComboBox/ComboBox.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,9 @@ export const ComboBox = ({
return !(typeof str === "string" && str.trim().length === 0)
}

const theId = id || "juno-combobox-" + useId()
const generatedId = useId()
const helptextId = "juno-combobox-helptext-" + useId()
const theId = id || "juno-combobox-" + generatedId
const [isOpen, setIsOpen] = useState(false)

const [optionValuesAndLabels, setOptionValuesAndLabels] = useState(
Expand Down
7 changes: 4 additions & 3 deletions packages/ui-components/src/components/RadioGroup/RadioGroup.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,12 @@ export const RadioGroup = ({
return !(typeof str === "string" && str.trim().length === 0)
}

const uniqueId = () => "juno-radiogroup-" + useId()
const generatedName = useId()
const generatedId = useId()

// Create unique identifiers for use with name and id of the group:
const groupName = name || uniqueId()
const groupId = id || uniqueId()
const groupName = name || "juno-radiogroup-" + generatedName
const groupId = id || "juno-radiogroup-" + generatedId

const [selectedValue, setSelectedValue] = useState<string | undefined>(selected)
const [isValid, setIsValid] = useState<boolean>(false)
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-components/src/components/SecretText/SecretText.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ export const SecretText = ({
return !(typeof str === "string" && str.trim().length === 0)
}

const uniqueId = () => "juno-secrettext-" + useId()
const theId = id || uniqueId()
const generatedId = useId()
const theId = id || "juno-secrettext-" + generatedId

const [isRevealed, setIsRevealed] = useState(false)
const [val, setVal] = useState("")
Expand Down
6 changes: 3 additions & 3 deletions packages/ui-components/src/components/Select/Select.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ export const Select = ({
return !(typeof value === "string" && value.trim().length === 0)
}

const uniqueId = () => "juno-select-" + useId()
const generatedId = useId()
const helptextId = "juno-select-helptext-" + useId()
const [isOpen, setIsOpen] = useState(false)

const theId = id || uniqueId()
const helptextId = "juno-select-helptext-" + useId()
const theId = id || "juno-select-" + generatedId

const [optionValuesAndLabels, setOptionValuesAndLabels] = useState(new Map<unknown, unknown>())
const [hasError, setHasError] = useState(false)
Expand Down
8 changes: 4 additions & 4 deletions packages/ui-components/src/components/Switch/Switch.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export const Switch = ({
wrapperClassName = "",
...props
}: SwitchProps): ReactNode => {
const generateUniqueId = (): string => "juno-switch-" + useId()
const generatedId = useId()

const [isOn, setIsOn] = useState<boolean>(on)
const [isInvalid, setIsInvalid] = useState<boolean>(false)
Expand Down Expand Up @@ -264,7 +264,7 @@ export const Switch = ({
if (onChange) onChange(event as unknown as ChangeEvent<HTMLButtonElement>)
}

const generatedId: string = id || generateUniqueId()
const theId: string = id || "juno-switch-" + generatedId

return (
<div>
Expand All @@ -279,7 +279,7 @@ export const Switch = ({
type="button"
role="switch"
name={name}
id={generatedId}
id={theId}
aria-checked={isOn}
disabled={disabled}
onClick={handleSwitchClick}
Expand All @@ -301,7 +301,7 @@ export const Switch = ({
></span>
</button>

<Label text={label} htmlFor={generatedId} className="jn:ml-2" disabled={disabled} required={required} />
<Label text={label} htmlFor={theId} className="jn:ml-2" disabled={disabled} required={required} />

{renderValidationIcon(isInvalid, isValid, disabled)}
</span>
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-components/src/components/TextInput/TextInput.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export const TextInput = ({
return !(typeof str === "string" && str.trim().length === 0)
}

const uniqueId = () => "juno-textinput-" + useId()
const generatedId = useId()

const ref = useRef<HTMLInputElement | null>(null)
const [val, setValue] = useState<string | number>("")
Expand Down Expand Up @@ -188,7 +188,7 @@ export const TextInput = ({
}
}

const theId = id || uniqueId()
const theId = id || "juno-textinput-" + generatedId

return (
<div className="juno-textinput-outer-wrapper">
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-components/src/components/Textarea/Textarea.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const Textarea = ({
return !(typeof str === "string" && str.trim().length === 0)
}

const uniqueId = () => "juno-textarea-" + useId()
const generatedId = useId()

const ref = useRef<HTMLTextAreaElement>(null)
const [val, setValue] = useState<string>("")
Expand Down Expand Up @@ -189,7 +189,7 @@ export const Textarea = ({
}
}

const theId = id || uniqueId()
const theId = id || "juno-textarea-" + generatedId

return (
<div>
Expand Down
Loading