Repository navigation
test: assert every declared e2e fixture build is visited by a spec - #1260
Merged
Merged
Conversation
A fixture build exists because tests/e2e/fixtures/data-<name>/ exists, and each one is a full Docusaurus compile, so the end-to-end coverage job's wall time is linear in those directories. The existing cases in this file hold every overlay to properties a stale fixture would break; none of them asks whether a browser ever opens the site compiled from it. A build no spec visits is served, never requested, and produces no capture artifact, so the union gains nothing from it and the arm its overlays hold open goes back to being uncovered -- at the price of a compile on every run. That is the same silent-no-op failure the overlay cases exist for, one level up: the symptom is a slower job and an uncovered arm, never an error. Matched against the spec sources with comments stripped, because the variant specs name one another's base URLs in their preambles; a commented mention is documentation, not a visit. The route boundary keeps a short build name from being credited by a longer one's URL. Closes #1259 Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
This PR is hold-gated and must not be auto-merged. Please apply 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88 |
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds one case to
tests/e2e-data-fixture-integrity.test.mjs: every name incoverageBuildNames()must appear as a route in at least onetests/e2e/*.spec.js.A fixture build exists because
tests/e2e/fixtures/data-<name>/exists, and each oneis a full Docusaurus compile (
tests/tools/e2e-coverage-builds.mjs), so theend-to-end coverage job's wall time is linear in those directories. The four cases
already in this file hold every committed overlay to properties a stale fixture would
break; none of them asks whether a browser ever opens the site compiled from it. A
build no spec visits is served, never requested, and produces no capture artifact, so
tests/tools/e2e-coverage-report.mjshas nothing of that build's to union and the armits overlays hold open goes back to being uncovered — at the price of a compile on
every run.
Scope:
tests/e2e-data-fixture-integrity.test.mjsonly. No production code, nopackage.jsonthresholds, no workflow files, no change to any existing case.Verification
TZ=UTC node --test tests/e2e-data-fixture-integrity.test.mjs— 6 pass, 0 fail.tests/e2e/fixtures/data-unvisited/makes the new case — and only the new case —fail naming that directory, while the four existing overlay cases stay green.
npm run test:unit:coverage:check(node v26.10.0,TZ=UTC) exits 0:src files | 100.00 | 100.00,harness files | 100.00 | 99.19,all files | 99.65 | 96.13.npx prettier --checkclean on the edited file.Related Issue
Closes #1259
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88