Repository navigation
test(bundle): drive labelCatalog.ts:80 (the /label allowlist's empty prefix) through dist/index.js - #448
Merged
Conversation
…prefix) through dist/index.js label-sync over a prow config with a labels.labels section must create its values verbatim, never as labels/<value>. The arm was green only in the unit suite; no bundle case composed that section. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
Contributor
|
Please add a kind label with |
mrbobbytables
approved these changes
Oct 11, 2026
mrbobbytables
deleted the
quality/test-label-sync-unprefixed-allowlist
branch
October 11, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/bundle/labelSyncUnprefixedAllowlist.test.ts: aworkflow_dispatch/jobs: label-syncrun over a prow config carrying both akindsection and alabelssection (one bare string, one{ name, color, description }entry). It asserts the POSTed label names aredocumentation,questionandkind/bugwith nolabels/prefix, that the configured color is lowercased, and that the request sequence is the config reads + one labels GET + one POST per label.Claimed ground:
src/utils/labelCatalog.ts:80(prefixed()'sprefix === ''arm —/labelis the one registry section with an empty prefix,src/labels/prefixed.ts:30). New file only; disjoint from #433 (stringLabelArm.test.ts) and #435 (labelSyncNullDescription.test.ts).Evidence (
main@ d0b1d87): unitnpx vitest run --coverage= 100 % lines (arm covered by__tests__/utils/labelCatalog.test.ts:52-58); e2enpm run test:coverage:e2eon origin/main + the 11 held bundle PR heads = 98.73 % lines,labelCatalog.ts:800 hits. With this test the line leaves the e2e residual.Related Issue
Refs #422 (hive folded this finding into its
dist/index.jstracker; #422's ownconfig.ts:305arm is PR #423's and the other folded findings remain open there)Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88