Skip to content

test(bundle): drive labelCatalog.ts:80 (the /label allowlist's empty prefix) through dist/index.js - #448

Merged
mrbobbytables merged 1 commit into
mainfrom
quality/test-label-sync-unprefixed-allowlist
Oct 11, 2026
Merged

mrbobbytables merged 1 commit into
mainfrom
quality/test-label-sync-unprefixed-allowlist

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds __tests__/bundle/labelSyncUnprefixedAllowlist.test.ts: a workflow_dispatch / jobs: label-sync run over a prow config carrying both a kind section and a labels section (one bare string, one { name, color, description } entry). It asserts the POSTed label names are documentation, question and kind/bug with no labels/ prefix, that the configured color is lowercased, and that the request sequence is the config reads + one labels GET + one POST per label.

Claimed ground: src/utils/labelCatalog.ts:80 (prefixed()'s prefix === '' arm — /label is the one registry section with an empty prefix, src/labels/prefixed.ts:30). New file only; disjoint from #433 (stringLabelArm.test.ts) and #435 (labelSyncNullDescription.test.ts).

Evidence (main @ d0b1d87): unit npx vitest run --coverage = 100 % lines (arm covered by __tests__/utils/labelCatalog.test.ts:52-58); e2e npm run test:coverage:e2e on origin/main + the 11 held bundle PR heads = 98.73 % lines, labelCatalog.ts:80 0 hits. With this test the line leaves the e2e residual.

Related Issue

Refs #422 (hive folded this finding into its dist/index.js tracker; #422's own config.ts:305 arm is PR #423's and the other folded findings remain open there)


Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

…prefix) through dist/index.js

label-sync over a prow config with a labels.labels section must create
its values verbatim, never as labels/<value>. The arm was green only in
the unit suite; no bundle case composed that section.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 11, 2026 11:10
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

@github-actions

Copy link
Copy Markdown
Contributor

Please add a kind label with /kind failing-test or /kind cleanup.

@mrbobbytables mrbobbytables left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally with all 10 P2 arm-test PRs stacked on main @ 850dbb0: npm run test:coverage:e2e 72 files / 452 tests pass; with the column-accurate map from #425 the targeted arm now registers hits (labelCatalog.ts:80 hit). Single new/extended test file, no overlap with the other PRs.

@mrbobbytables
mrbobbytables merged commit 4bc6c3a into main Oct 11, 2026
10 checks passed
@mrbobbytables
mrbobbytables deleted the quality/test-label-sync-unprefixed-allowlist branch October 11, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Indicates that a PR should not merge because someone has issued a /hold command. needs-kind

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant