Make the runtime observable for operators (O-8) - #29
Open
windischb wants to merge 1 commit into
Open
Conversation
Both stream managers were private without a count - a leaked stream was unmeasurable and invisible - and the backplane had no health surface: no node list, no last-heartbeat, no way to notice the heartbeat loop had died before the cluster declares the node dead and wipes its registrations. ServerStreamManager now counts (ActiveStreamCount, signalarrr.server. active_streams) and reaps streams that were created but never consumed (StreamIdleTimeout, default 10 min; streams with a reader attached are never touched - their lifecycle ends via the read loop or disconnect cleanup). Upload-slot sweeps are counted too. The backplane exposes GetActiveNodesAsync and a health surface (last successful heartbeat, loop-faulted, PING), and services.AddSignalARRRHealthChecks() turns all of it into a standard health check: heartbeat-loop dead or store unreachable -> Unhealthy, heartbeat stale beyond two intervals -> Degraded before the cluster acts, node list in the data. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Block 7, PR 4 of the agreed slicing — finding O-8 from the 2026-08 review. Completes the O-block.
ServerStreamManager.ActiveStreamCount, pending download/upload-slot counts, and instrumentssignalarrr.server.active_streams/.streams.reaped/.upload_slots.swept. Leaked streams used to be unmeasurable and invisible.StreamIdleTimeout(default 10 min,WithStreamIdleTimeout); their producer gets a completing error instead of writing into the void. Streams with a reader attached are never touched — their lifecycle ends via the read loop''sfinallyor the disconnect cleanup.GetActiveNodesAsync()(self + live remotes), last successful heartbeat, heartbeat-loop-faulted, and a Redis PING.services.AddSignalARRRHealthChecks(): standardIHealthCheck(namesignalarrr). Verdicts an operator can act on: heartbeat loop dead or store unreachable → Unhealthy; heartbeat stale beyond two intervals → Degraded (the warning before the cluster declares the node dead and wipes its registrations — the V-3 scenario); node list and counts in the health data. Without a backplane: Healthy with the stream counts.Verification
/healthendpoint on the real server returnsHealthy.🤖 Generated with Claude Code