Repository navigation
INTEG-3268 - fix bug in trusted_activities iter_all - #188
Merged
ceciliastevens merged 2 commits intoSep 30, 2026
Merged
Conversation
ceciliastevens
force-pushed
the
bugfix/INTEG-3268/infinite-trusted-activities-loop
branch
from
September 29, 2026 14:20
d56e134 to
51de4f4
Compare
jdullum
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trusted-activities API always returns a full page size, leading to an infinite loop with the old logic. This fixes it by keeping track of the IDs on the last page, only emitting what we haven't already emitted, and then stopping iteration when we have a smaller-than-full-page worth of trusted activities to emit.