Repository navigation
IIIFの題名の既定をManifestのlabelに統一 - #165
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更
IIIF の書誌を地図へ写す際、
proposeIiifBindingsのtitleの既定を常に{ from: "manifest", property: "label" }にしました。canvas の label が「page 1」でも Manifest の書名を提案します。Manifest の label が読めない場合は title を返しません。利用者が「このコマ」を選ぶための明示的な canvas の指定は維持しています。不要な数字・空文字判定を削除し、README(英日)と CHANGELOG を更新しました。
検証
node_modules/.bin/eslint src spec: エラー0件、既存の警告2件pnpm run build: 成功、バンドル検査も成功#145〜#147 に合わせ、build で生成した dist の差分(型定義・ソースマップ)を専用コミットに含めています。マージは行っていません。
🤖 Generated with Claude Code