Repository navigation
fix(playwright): start no browser in _beforeSuite with restart: browser (#5784) - #5785
Open
danielrentz wants to merge 1 commit into
Open
danielrentz wants to merge 1 commit into
danielrentz wants to merge 1 commit into
Conversation
…er (codeceptjs#5784) With the browser restart strategy, _before() starts a browser for each test. The browser that _beforeSuite() started was replaced by the one of the first test and never closed, so each test file left one browser running.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
restart: trueorrestart: 'browser',_before()starts a browser for each test._beforeSuite()started one more browser for each test file, which the first test replaced without closing it, so one browser per test file kept running until the process ended._beforeSuite()now starts no browser with this restart strategy.restart: trueleaks one browser per test file #5784Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test):test/uniton Windows; the 12 tests that fail there fail on4.xwithout this change as well