Bug: Route Filters Are Ignored When Using Custom Placeholders in Routing #9804

Activity

1. frkiergn

   added

   bugVerified issues on the current code behavior or pull requests that will fix themVerified issues on the current code behavior or pull requests that will fix them

   on Nov 19, 2025
2. michalsn commented on Nov 20, 2025

   

   michalsn

   on Nov 20, 2025

   Member

   More actions

   Thank you for reporting. I can only confirm this partially.

   For the case you described, following the provided steps, I was able to run filters correctly.

   However, the issue still persists with the php spark routes command.

   I haven't worked closely with this part of the framework before, but it seems that SampleURIGenerator::samples is used to detect the correct placeholder pattern. We likely need a way to seed SampleURIGenerator with custom samples for new placeholders. Perhaps we could store them in app/Config/Routing.php, though I'm not entirely sure this is the best way to handle this.
3. neznaika0 commented on Dec 5, 2025

   

   neznaika0

   on Dec 5, 2025

   Contributor

   More actions

   Confirm. Global filters are applied. There are no unique routes.
   I can add the feature to the generator. But I don't like that the user will need to add values. I don't see any other option yet.

   It sounds silly. There may be problems if the user overwrites the basic placeholders or examples for them.

   // app/Config/Routing.php
   /**
    * Acceptable values for a custom route placeholder.
    *
    * After creating a custom placeholder, set one of the acceptable values for it.
    * You can skip this step, then the `spark routes` command will not work correctly.
    *
    * @var array<string, string>
    */
   public array $placeholderValues = [
       'test' => 'hello01',
       'num'  => 'slug::word', // replace basic placeholder
   ];
   
   // system/Commands/Utilities/Routes/SampleURIGenerator.php
   final class SampleURIGenerator
   {
       private readonly RouteCollection $routes;
   
       /**
        * Sample URI path for placeholder.
        *
        * @var array<string, string>
        */
       private array $samples = [
           'any'      => '123/abc',
           'segment'  => 'abc_123',
           'alphanum' => 'abc123',
           'num'      => '123',
           'alpha'    => 'abc',
           'hash'     => 'abc_123',
           // after merge input values
           // 'test' => 'hello01',
           // 'num'  => 'slug::word',
       ];
   
       public function __construct(?RouteCollection $routes = null, array $samples = [])
   // or config
       public function __construct(?RouteCollection $routes = null, ?Routing $routing = null)
4. neznaika0 commented on Dec 6, 2025

   

   neznaika0

   on Dec 6, 2025

   Contributor

   More actions

   I thought the function wasn't perfect.
   For complex route options, the result will be unexpected. It might be worth moving it to routes:check POST /posts/123.

   There are many variable parameters to accurately determine the information.
   The route may have "excerpt" filters - /posts/123 will not give the same for /posts/slug. But for example, he can apply 123 for a placeholder, then the slug filters will be different.
5. jalexiscv

   added 2 commits that reference this issue on May 18, 2026

   fix: generate valid sample URIs for custom route placeholders

   ...

   This issue will close once commit 31f6444 is merged into the 'main' branch.

   31f6444

   fix: add sample parameter to addPlaceholder() for valid route URIs

   ...

   This issue will close once commit fc75029 is merged into the 'main' branch.

   fc75029
6. paulbalandan

   linked a pull request that will close this issuefeat: resolve spark routes filters for custom placeholders #10263on Jun 1, 2026
7. paulbalandan commented on Jun 5, 2026

   

   paulbalandan

   on Jun 5, 2026

   Member

   More actions

   Fixed in #10263
8. paulbalandan

   closed this as completedon Jun 5, 2026