fix: resolve race condition in get_dir_file_info() when files are deleted concurrently#10406
Closed
gr8man wants to merge 3 commits into
Closed
fix: resolve race condition in get_dir_file_info() when files are deleted concurrently#10406gr8man wants to merge 3 commits into
gr8man wants to merge 3 commits into
Conversation
This squashes several fixes regarding Entity::toRawArray returning string values instead of Time objects, addressing issue codeigniter4#8302. It also updates DatetimeCast to handle string values to prevent DataConverter crashes, and applies phpstan, rector, and cs-fix formatting.
gr8man
force-pushed
the
test/filesystem-helper-race-condition
branch
from
ecd4a6b to
97baf02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When scanning directories,
get_dir_file_info()could encounter a race condition if a file was deleted right after being read byreaddir(). In this scenario,get_file_info()would returnnull, causing an incomplete entry (lackingserver_pathor other keys) to be added to the result array.This PR adds a null check to gracefully ignore files deleted mid-scan, which also prevents broken entries from being created when passing directories with
$topLevelOnly = true. This fixes random test failures observed in theCommandscomponent. A unit test has been added to ensure the correct behavior.Checklist: