Repository navigation
feat: modernise colour detection with FORCE_COLOR, COLORTERM and TERM=dumb - #10653
Open
paulbalandan wants to merge 1 commit into
Open
paulbalandan wants to merge 1 commit into
paulbalandan wants to merge 1 commit into
Conversation
michalsn
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our colour detection came from
composer/xdebug-handler, which has since dropped it.Terminal::hasColorSupport()now follows Symfony'sStreamOutput::hasColorSupport(), keeping one difference: a TTY on Unix gets colour whatever itsTERM, where Symfony requiresTERMto match its pattern.The checks run in this order:
NO_COLORturns colour off.FORCE_COLORturns it on, even when the output is piped.MINGW32andMINGW64.TERM_PROGRAM=Hyper,COLORTERM,ANSICONorConEmuANSI=ONturns it on.TERM=dumbturns it off.TERMto match Symfony's pattern (xterm*,cygwin*,*-256colorand similar).The variables are read through
env(), so they can also be set in .env.NO_COLORandFORCE_COLORcount only when they are not empty, whatever the value, as no-color.org and force-color.org specify.Behaviour changes, listed in the changelog:
NO_COLORno longer turns colour off.TERM=dumbturns colour off.ANSICON, ConEmu orTERM.TERMvalues now get colour, where previously onlyxtermdid.Checklist: