Repository navigation
fix(publish): build uploader before publishing - #221
Merged
Merged
Conversation
changeset publish runs every unpublished package's prepublishOnly at the same time, so @medialit/react's dts build could read uploader's dist while uploader's own tsup run was cleaning it. Build uploader once before the publish step, and drop its prepublishOnly so nothing rebuilds it mid-publish. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
test:conformance ran every test file with a name filter. Files whose tests are all filtered out still run their top-level before hooks. The dashboard test's hook never finished under the filter, and its PGlite instance kept the process alive, so the conformance job hung. Run the conformance file directly instead. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish run for #203 failed partway: `@medialit/react` could not find `@medialit/uploader`'s type declarations, because `changeset publish` runs every package's `prepublishOnly` concurrently and uploader's `tsup` cleans its `dist` while react's build reads it.
Verified locally: uploader builds from a clean `dist`, then react's build succeeds against it.
Merging this does not publish anything by itself. The publish workflow runs on the next push to `main`.
🤖 Generated with Claude Code