Repository navigation
feat: delete draft broadcasts, archive sent ones (#147) - #165
Merged
Merged
Conversation
…147) Sent broadcasts answer 409 broadcast_sent and are archived instead (sequences.archived_at): hidden from GET /sequences unless archived=only|include, removed from the web archive, feed and sitemap, report and media kept. Adds POST /sequences/:id/archive and /unarchive, MCP archive_broadcast and unarchive_broadcast, and broadcast_archived/unarchived events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147. Part of #152.
What
409 sequence_active. Broadcasts that started sending (sent or paused mid-send) →409 broadcast_sent; the delete statement re-checks so a broadcast locking concurrently is kept.sequences.archived_at(migration 0028, additive, previous-release compatible).POST /sequences/:id/archive(sent only;409 broadcast_not_sent/sequence_active),POST /sequences/:id/unarchive.GET /sequenceshides archived unlessarchived=only|include. Report, deliveries and media kept. Archived paused-mid-send broadcasts can't resume until restored./w/:handle, issue page, feed and sitemap; unarchive restores. Per-recipient "view in browser" keeps working. ADR 0008.delete_sequence(reused, consistent with Delete sequences #148) explainsbroadcast_sent; newarchive_broadcast,unarchive_broadcast;list_sequencesgetsarchived. 113 tools.broadcast_archived,broadcast_unarchived(props already allowlisted).Verification
--env-file=/dev/null), web 106/0,check:drift,test:conformanceall pass.409 broadcast_sent; archived from the list menu → gone from list, shown under Archived, stats unchanged (sent 2), deliveries and media kept, no MediaLit delete, gone from/w/:handle, issue 404, feed and sitemap; unarchived from the detail page → back in list and on the web; deleted a draft (list) and a scheduled broadcast (detail page) → rows, rule and media gone, MediaLit DELETE observed for each; archiving a draft →409 broadcast_not_sent. 40/40 checks passed; screenshots inspected.