fix(landjail): allow TCP bind under Landlock#210
Open
openmarmot wants to merge 1 commit into
Open
Conversation
Landlock V4 handles both bind_tcp and connect_tcp. Restricting with only connect rules denied all binds, breaking local servers like opencode web. Handle connect only so egress stays proxy-only while bind/listen remains unrestricted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(landjail): allow TCP bind under Landlock
Problem
With
--jail-type landjail, processes that listen on a local TCP port fail immediately (e.g.opencode web→ServeError/ bind permission denied).Landlock ABI V4 covers both
bind_tcpandconnect_tcp. Landjail usedlandlock.V4.RestrictNet(...)with onlyConnectTCP(proxyPort)rules. Because bind was handled but never allowed, all binds were denied (EACCES), while connect to the proxy still worked.Change
In
landjail/child.go, restrict connect only:AccessNetConnectTCPEgress remains proxy-only. Local servers inside the jail can bind normally.
Docs updated in
docs/architecture.md.How to test