first draft - #683
first draft#683DerBurri wants to merge 133 commits into
Check failed
There are 4 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🔴 | 79d13b1 | first draft | Sign-off not found |
| 🟢 | 937e8c1 | chore(docs): Auto-update docs and licenses | Valid sign-off found |
| 🟢 | d09ae9a | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | 2d3d6ac | update(deps): update module github.com/argoproj/ar... | Skipped: sign-off not required for members |
| 🟢 | aaee923 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | 676731d | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | c4752e5 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | 91d8bae | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required for members |
| 🟢 | e57874c | feat(openfga): add the openFga block to the instal... | Skipped: sign-off not required for members |
| 🟢 | 4effac8 | feat(oms): confirm secret changes in update instal... | Skipped: sign-off not required for members |
| 🟢 | ef278cf | feat(openfga): derive the pc-applications values (... | Skipped: sign-off not required for members |
| 🟢 | 96dec98 | update(deps): update module helm.sh/helm/v4 to v4.... | Skipped: sign-off not required for members |
| 🟢 | 8c5e88e | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | 2506e2a | update(deps): update go module directive to v1.26.... | Skipped: sign-off not required for members |
| 🟢 | 63e7dbf | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required for members |
| 🟢 | 9646eff | update(deps): update module golang.org/x/mod to v0... | Skipped: sign-off not required for members |
| 🟢 | e65a2d0 | refac(gcp): model the data centers of a bootstrap ... | Skipped: sign-off not required for members |
| 🟢 | 1864949 | feat(gcp): derive the VM definitions per data cent... | Skipped: sign-off not required for members |
| 🟢 | 8b79412 | Refactor vault handling (#642) | Skipped: sign-off not required for members |
| 🟢 | a8ea136 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | 2643f09 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | 4e3a282 | update(deps): update module github.com/stretchr/te... | Skipped: sign-off not required for members |
| 🟢 | 42727f8 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | d98dfe0 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required for members |
| 🟢 | beeafc0 | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required for members |
| 🟢 | c6f2644 | update(deps): update module google.golang.org/grpc... | Skipped: sign-off not required for members |
| 🟢 | 1205ef5 | update(deps): update actions/checkout digest to d2... | Skipped: sign-off not required in bot commit |
| 🟢 | b9cc692 | update(deps): update actions/setup-go digest to 92... | Skipped: sign-off not required in bot commit |
| 🟢 | fec4124 | fix(installer): cap Helm release history at 10 rev... | Skipped: sign-off not required for members |
| 🟢 | 7f98dc4 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | c340954 | update(deps): update module github.com/stretchr/te... | Skipped: sign-off not required in bot commit |
| 🟢 | 469acc8 | update(deps): update module github.com/golangci/go... | Skipped: sign-off not required in bot commit |
| 🟢 | c44b88a | update(deps): update module k8s.io/cri-streaming t... | Skipped: sign-off not required in bot commit |
| 🟢 | 05c07e1 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 6feeb12 | update(deps): update kubernetes monorepo to v0.36.... | Skipped: sign-off not required in bot commit |
| 🟢 | 472532a | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | a7b45be | update(deps): update module k8s.io/kubernetes to v... | Skipped: sign-off not required in bot commit |
| 🟢 | a4a7fa0 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 0dd33ce | update(deps): update module k8s.io/streaming to v0... | Skipped: sign-off not required in bot commit |
| 🟢 | 9753039 | update(deps): update go module directive to v1.27.... | Skipped: sign-off not required in bot commit |
| 🟢 | 364c5df | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | a84f0fd | update(deps): update actions/checkout action to v7... | Skipped: sign-off not required in bot commit |
| 🟢 | 529be6c | update(deps): update actions/setup-go action to v7... | Skipped: sign-off not required in bot commit |
| 🟢 | 9f13adb | update(deps): update endbug/add-and-commit action ... | Skipped: sign-off not required in bot commit |
| 🟢 | 0884cac | update(deps): update module github.com/azure/azure... | Skipped: sign-off not required in bot commit |
| 🟢 | 0bf8118 | feat(cli): add oms copy package command for transf... | Skipped: sign-off not required for members |
| 🟢 | 9a4198a | update(deps): update module github.com/prometheus/... | Skipped: sign-off not required in bot commit |
| 🟢 | f6d29c2 | update(deps): update module github.com/google/go-c... | Skipped: sign-off not required in bot commit |
| 🟢 | cf1486f | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 5aa1f48 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | f7b4c2a | update(deps): update module github.com/vektra/mock... | Skipped: sign-off not required in bot commit |
| 🟢 | 082f562 | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | 0b11a6b | update(deps): update module github.com/goreleaser/... | Skipped: sign-off not required in bot commit |
| 🟢 | 591dd35 | update(deps): update module github.com/google/go-g... | Skipped: sign-off not required for members |
| 🟢 | 5a29516 | fix(installer): move MetalLB config under Cluster ... | Skipped: sign-off not required for members |
| 🟢 | f0fa688 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | a55321d | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | b1149bb | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | 7732219 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 546c7bc | update(deps): update module google.golang.org/grpc... | Skipped: sign-off not required in bot commit |
| 🟢 | 1cd8526 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 7da9b11 | update(deps): update module github.com/google/go-c... | Skipped: sign-off not required in bot commit |
| 🟢 | a7b3c0f | Config Templating: Update doc strings and docs wit... | Skipped: sign-off not required for members |
| 🟢 | 0482667 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 60d164b | refac(internal/github): single graphql query to fe... | Skipped: sign-off not required for members |
| 🟢 | ce0a1c4 | update(deps): update module google.golang.org/api ... | Skipped: sign-off not required in bot commit |
| 🟢 | 80631df | update(deps): update module k8s.io/cri-streaming t... | Skipped: sign-off not required in bot commit |
| 🟢 | 489fce8 | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | 3561789 | update(deps): update module k8s.io/streaming to v0... | Skipped: sign-off not required in bot commit |
| 🟢 | 30a890d | feat(bootstrap): manage local infrastructure with ... | Skipped: sign-off not required for members |
| 🟢 | 4bf649b | update(deps): update module github.com/argoproj/ar... | Skipped: sign-off not required in bot commit |
| 🟢 | b8d48bd | update(deps): update module cloud.google.com/go/co... | Skipped: sign-off not required in bot commit |
| 🟢 | 5a41502 | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | e59bfed | update(deps): update module github.com/golangci/go... | Skipped: sign-off not required in bot commit |
| 🟢 | f0184cb | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 58860b1 | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | 012b525 | feat: add pc apps defaults to include managed serv... | Skipped: sign-off not required for members |
| 🟢 | 56e18e7 | feat!: move default managed service config from in... | Skipped: sign-off not required for members |
| 🟢 | 2d87293 | chore: add new providers to GCP bootstrap defaults... | Skipped: sign-off not required for members |
| 🟢 | 6cf91dc | chore: enable ms-backend-opensearch on gcp bootstr... | Skipped: sign-off not required for members |
| 🟢 | d65117f | update(deps): update module google.golang.org/api ... | Skipped: sign-off not required in bot commit |
| 🟢 | 6f01ce0 | update(deps): update module filippo.io/age to v1.3... | Skipped: sign-off not required in bot commit |
| 🟢 | 841f091 | feat(gcp): enable KubeVirt/CDI for GCP QA installs... | Skipped: sign-off not required for members |
| 🟢 | 57c892c | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | bfce566 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | fdc4e52 | update(deps): update module google.golang.org/api ... | Skipped: sign-off not required in bot commit |
| 🟢 | 9412821 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 9e394b5 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | fa4e78e | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | 710af2b | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 3943f59 | update(deps): update module google.golang.org/api ... | Skipped: sign-off not required in bot commit |
| 🟢 | d088995 | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | 2278710 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 54f38eb | update(deps): update module golang.org/x/crypto to... | Skipped: sign-off not required in bot commit |
| 🟢 | 23c18f3 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | b235ba4 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | ccd0a70 | update(deps): update module github.com/google/go-c... | Skipped: sign-off not required in bot commit |
| 🟢 | 6e22a4b | chore(bootstrap): refactor k0s gcp bootstrapping p... | Skipped: sign-off not required for members |
| 🟢 | 7d8bada | chore: format gcp bootstrap cli files (#781) | Skipped: sign-off not required for members |
| 🟢 | ae1ac8b | fix(managed-services): Only enable url-shortener o... | Skipped: sign-off not required for members |
| 🟢 | c712e2a | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | b7d25c1 | update(deps): update module golang.org/x/mod to v0... | Skipped: sign-off not required in bot commit |
| 🟢 | 371aa31 | update(deps): update module golang.org/x/oauth2 to... | Skipped: sign-off not required in bot commit |
| 🟢 | eb4e7f1 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | bca2dec | update(deps): update module golang.org/x/crypto to... | Skipped: sign-off not required in bot commit |
| 🟢 | 30d94df | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | d1e2cc9 | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | 50a825e | update(deps): update module github.com/onsi/ginkgo... | Skipped: sign-off not required in bot commit |
| 🟢 | 22aa534 | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | e011db7 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | e0757c6 | update(deps): update module helm.sh/helm/v4 to v4.... | Skipped: sign-off not required in bot commit |
| 🟢 | f4ad29d | feat(gcp): configure hosts, gateways and installs ... | Skipped: sign-off not required for members |
| 🟢 | 4e5722e | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | c6abda1 | update(deps): update module cloud.google.com/go/co... | Skipped: sign-off not required in bot commit |
| 🟢 | 482a4b5 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | ec1f4fa | feat(fga): add openfga backup to bootstrap (#595) | Skipped: sign-off not required for members |
| 🟢 | 4a97a60 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | a252500 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | bc05761 | update(deps): update module github.com/argoproj/ar... | Skipped: sign-off not required in bot commit |
| 🟢 | 85988eb | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🟢 | 2b69246 | feat: implement email validation and enhance API k... | Skipped: sign-off not required for members |
| 🟢 | 9eba02f | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 5833c74 | update(deps): update module google.golang.org/api ... | Skipped: sign-off not required in bot commit |
| 🟢 | 0c2bef8 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 2564f8f | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | d9dd119 | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | ea912db | update(deps): update github.com/rook/rook/pkg/apis... | Skipped: sign-off not required in bot commit |
| 🟢 | 42361cc | update(deps): update module github.com/codesphere-... | Skipped: sign-off not required in bot commit |
| 🔴 | 182f1d4 | first draft | Sign-off not found |
| 🟢 | 61cb37f | chore(docs): Auto-update docs and licenses | Valid sign-off found |
| 🟢 | 9e688f9 | Fix naming conflict | Skipped: sign-off not required in merge commit |
| 🔴 | bd737af | tests: mark the smoketest command as deprecated | Sign-off not found |
| 🔴 | 6695aca | Mark the old smoketest command as deprectated | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~133 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feat/cli-test-playlist