fix: backlog — addKeyword empty, QR validation, sharp engines, meta webhook notice, endFlow tests, venom CI matrix - #1259
Open
ipproyectosysoluciones wants to merge 14 commits into
Conversation
addKeyword([]) and addKeyword('') now throw 'Keyword cannot be empty'
via a single keyword.length === 0 guard. Prevents empty-keyword flows.
test: RED -> GREEN (13/13) in methods.test.ts
indexHome now checks existsSync(qrPath) and returns 404 JSON when the QR has not been generated, instead of streaming an unhandled ENOENT. test: 29/29 (new 404 case)
sharp@0.33.x breaks on Node < 20.12.1. Bump root engines.node to
>=20.12.1 <23.0.0 and add engines { node: >=20.12.1 } to the 6
packages that depend on sharp.
afterHttpServerInit now emits a WEBHOOK REQUIRED notice after ready, reminding to configure the callback URL and subscribe to messages. test: 68/68
The endFlow + capture:true flow was already fixed; 5 tests were left skipped. Unskip them -> 6/6 pass.
Matrix Node 18.19/20.10/21.7.2 x ubuntu/windows for provider-venom, triggered on provider-venom changes or manual dispatch.
actions/checkout tried to init a malformed 'wa-calls-ref' submodule (no url in .gitmodules) and failed. Disable submodules like crm-ci.yml.
Replace obsolete Node 18.19/20.10 with 20.12.1/21.7.2/22.20.0.
pnpm/action-setup conflicted between version:9 and packageManager pnpm@9.0.6. Align to the exact packageManager version.
Node 20.12.1/21.7.2 are non-LTS and sharp has no prebuilt binaries for them, so builds time out (20m). Node 22 LTS passes in ~5m.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six focused fixes from the backlog, each in a conventional commit.
Changes
addKeyword([])/addKeyword('')(keyword.length === 0guard)existsSync→ 404 JSON instead of unhandled ENOENT)>=20.12.1forsharp@0.33.x(root + 6 packagesengines)WEBHOOK REQUIREDnotice afterready(reminder to configure callback URL + subscribe tomessages)Verification
@builderbot/botmethods: 13/13 · e2e endFlow: 6/6@builderbot/provider-venom: 29/29@builderbot/provider-meta: 68/68Notes
CONTRIBUTING.mdand TS target bump were left out of this PR (they depend on builderbot's current state) — can be split into a separate PR if desired.