ci: fix upload-artifact node24 upgrade and bump remaining node20 actions - #48
Merged
Conversation
actions/upload-artifact@v5 still bundles Node 20 (the deprecation warning persisted after the previous bump) — its action.yml targets node20 up through v5; node24 support only starts at v6. Bump to v7 (latest stable, node24-native). While auditing, also bumped the two other actions still declaring node20: actions/download-artifact@v5 -> v8 and softprops/action-gh-release@v2 -> v3, both node24-native. Verified all inputs currently used (pattern/path/merge-multiple for download-artifact; name/files/generate_release_notes/prerelease for action-gh-release) are still supported in the new majors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/upload-artifactto@v5, assuming v5 was the node24-native major — it isn't. Checked upstreamaction.ymldirectly: v5 still declaresnode20; node24 support only starts at v6. Bumped tov7(latest stable, node24-native), which is why the deprecation warning persisted after that change.action.yml, found two more still on node20 and bumped them too:actions/download-artifact@v5->v8(node20 through v6, node24 from v7+)softprops/action-gh-release@v2->v3(node20 through v2, node24 in v3)pattern/path/merge-multiplefor download-artifact;name/files/generate_release_notes/prereleasefor action-gh-release) are still supported in the new majors.Test plan