Nojira/time core session - #582
Draft
mikejritter wants to merge 5 commits into
Draft
mikejritter wants to merge 5 commits into
mikejritter wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds logging for total time elapsed when using a CoreSession
Why are we doing this? (with JIRA link)
No jira. This is an idea I had to try and track which sessions are being held on to longer than the default timeout.
It would be good to discuss the default value. Initially I was thinking of using 1 second, but when thinking further it seemed like maybe 250ms is a good starting point. My only concern would be that is too short and we might see many sessions being used for that long.
Also, at the moment you need to correlate the log with the http thread its being executed on. This could be extended to include the query, or some other bookkeeping to make it easier, however I wanted to keep this fairly simple for now (and some of the housekeeping has already made the PR larger than it needs to be).
How should this be tested? Do these changes have associated tests?
NuxeoRepositoryClientImpl#getFilteredaftergetRepositorySession(ctx))Dependencies for merging? Releasing to production?
No dependencies.
Has the application documentation been updated for these changes?
n/a
Did someone actually run this code to verify it works?
@mikejritter ran locally
Have any new security vulnerabilities been handled?
n/a