DRYD-2207: Add Micrometer - #584
Open
mikejritter wants to merge 14 commits into
Open
mikejritter wants to merge 14 commits into
mikejritter wants to merge 14 commits into
Conversation
This allows us to perform the tasks done by CSpaceResteasyBoostrap which are a mix of updating the Resteasy context and post-init tasks.
This is the start of adding micrometer and adding a metrics endpoint, more to come later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
cspace.metrics.enabledenvironment variable for enabling MetricsResourceWhy are we doing this? (with JIRA link)
jira: https://collectionspace.atlassian.net/browse/DRYD-2207
This is being done so that we can better track performance of CollectionSpace and see what types of issues we might be encountering. It adds various metrics (JVM, Tomcat, Response Time), so that we can a good view of the internals of the application, from heap usage, garbage collection, to the application server, and responsiveness of serving requests.
To go over some of the internals and decisions made:
/cspace-services) is removed and UUIDs/refnames are replaced with templated strings to reduce cardinality.Everything else I think is fairly straightforward, not too much to go over.
How should this be tested? Do these changes have associated tests?
bin/setenv.sh, add-Dcspace.metrics.enabled="true"to enable metricsor just use
--verboseDependencies for merging? Releasing to production?
This is built on #583, so we should review/merge that first then I can rebase so the changes are a bit smaller. I wanted to try the stacked PRs but I don't think I initially did things in the correct order (and I also don't generally use the gh tooling).
Other things we will need to do:
Has the application documentation been updated for these changes?
Documentation will need to be added for the new environment variable
Did someone actually run this code to verify it works?
@mikejritter ran locally
Have any new security vulnerabilities been handled?
n/a so far.