Repository navigation
check_for_release: compare against the release marked as latest - #125
Merged
Merged
Conversation
The deploy path has taken /releases/latest since #55, the check still sorted the list. A repo that does not flag its betas as prereleases then offered the beta with the higher number, and the deploy answered "already installed" with the stable release: FileBrowser Quantum reported 2.1.0-beta on every run and the addon failed after the skipped download, AudioMuse offered v5.0.0-model. Pins, tag prefixes and the prerelease opt-in still read the list.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/check-release-designated-latest \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/check-release-designated-latest/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/check-release-designated-latestNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
check_for_releaseasks/releases/latestfirst, like the deploy path does since github-api: take the release the maintainer marked as latest #55GH_INCLUDE_PRERELEASE=1still read the listRepos that do not flag betas as prereleases offered the beta on every run while the deploy kept the stable release:
🔗 Related Issue
Related: community-scripts/ProxmoxVE#17809
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.