Skip to content

check_for_release: compare against the release marked as latest - #125

Merged
MickLesk merged 1 commit into
mainfrom
fix/check-release-designated-latest
Oct 9, 2026
Merged

MickLesk merged 1 commit into
mainfrom
fix/check-release-designated-latest

Conversation

@MickLesk

@MickLesk MickLesk commented Oct 9, 2026

Copy link
Copy Markdown
Member

✍️ Description

Repos that do not flag betas as prereleases offered the beta on every run while the deploy kept the stable release:

repo installed before after
gtsteffaniak/filebrowser 2.0.0-stable update to 2.1.0-beta no update
NeptuneHub/AudioMuse-AI 3.6.3 update to 5.0.0-model no update
jellyfin/jellyfin 10.0.0 update to 12.2 update to 12.2

🔗 Related Issue

Related: community-scripts/ProxmoxVE#17809

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

The deploy path has taken /releases/latest since #55, the check still
sorted the list. A repo that does not flag its betas as prereleases then
offered the beta with the higher number, and the deploy answered
"already installed" with the stable release: FileBrowser Quantum reported
2.1.0-beta on every run and the addon failed after the skipped download,
AudioMuse offered v5.0.0-model. Pins, tag prefixes and the prerelease
opt-in still read the list.
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/check-release-designated-latest \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/check-release-designated-latest/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/check-release-designated-latest

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk
MickLesk merged commit 1f09345 into main Oct 9, 2026
5 checks passed
@github-actions
github-actions Bot deleted the fix/check-release-designated-latest branch October 10, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant