Skip to content

gh: curl_download: wait between attempts #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MickLesk merged 1 commit into from
Oct 12, 2026
Merged

gh: curl_download: wait between attempts #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/system.func
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2206,9 +2206,11 @@ ensure_usr_local_bin_persist() {
# for 60 consecutive seconds (i.e. a genuine stall or dead connection).
# Retries up to 3 times on failure, continuing where the last attempt stopped:
# starting a 1.5 GB archive over on every stall is how large downloads kept
# failing. The last attempt goes over IPv4, since a broken IPv6 path is a
# common cause of stalls. The file is written to <output>.part and moved into
# place only when complete, so a failure leaves an existing <output> intact.
# failing. Attempts are 10 s and 20 s apart: back to back, a CDN answering 504
# for a few seconds used up all three. The last attempt goes over IPv4, since a
# broken IPv6 path is a common cause of stalls. The file is written to
# <output>.part and moved into place only when complete, so a failure leaves an
# existing <output> intact.
# Returns 0 on success, 7 if all attempts fail.
# ------------------------------------------------------------------------------
curl_download() {
Expand Down Expand Up @@ -2239,7 +2241,8 @@ curl_download() {
# 33: the server cannot resume, so the next attempt starts over.
((rc == 33)) && rm -f "$part"
if ((attempt < retries)); then
msg_warn "Download failed or stalled (attempt ${attempt}/${retries}), retrying..."
msg_warn "Download failed or stalled (attempt ${attempt}/${retries}), retrying in $((attempt * 10))s..."
sleep $((attempt * 10))
fi
((attempt++))
done
Expand Down
Loading