Skip to content

Show what the failing command printed, and keep verbose output in the log - #139

Merged
MickLesk merged 5 commits into
mainfrom
feat/show-failed-command-output
Oct 14, 2026
Merged

MickLesk merged 5 commits into
mainfrom
feat/show-failed-command-output

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

The host only forwarded the .errinfo capture to telemetry, so the user saw "exit code 1" and nothing else. Verbose mode bypassed silent() entirely, leaving the install log without the command output that the issue template asks for

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

… log

The host only forwarded the .errinfo capture to telemetry, so the user
saw "exit code 1" and nothing else. Verbose mode bypassed silent()
entirely, leaving the install log without the command output that the
issue template asks for (ProxmoxVE #17913).
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/feat/show-failed-command-output \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

This PR touches both backends. Worth running on a Proxmox VE and an Incus host.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/feat/show-failed-command-output/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/feat/show-failed-command-output

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

…and-output

# Conflicts:
#	.github/workflows/verify-split-files.yml

Co-authored-by: MickLesk <47820557+MickLesk@users.noreply.github.com>

Copilot AI commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in merge commit 970df02. Both branches’ regression test paths and steps are preserved. All 41 targeted assertions passed, with syntax checks, ShellCheck, and CodeQL also passing.

…and-output

# Conflicts:
#	.github/workflows/verify-split-files.yml
… into feat/show-failed-command-output

# Conflicts:
#	.github/workflows/verify-split-files.yml
@MickLesk
MickLesk merged commit fbc2e15 into main Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants