Make eq polynomial helpers generic over SumcheckField#110
Open
Praz314159 wants to merge 1 commit into
Open
Conversation
Port compute_hypercube_eq_evals, eq_poly, and eq_poly_non_binary from ark_ff::Field to the portable SumcheckField trait and drop the arkworks feature gate, so non-arkworks fields can use these eq primitives.
Author
|
@z-tech :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the eq polynomial helpers usable without the arkworks feature by porting them from ark_ff::Field to the crate's SumcheckField trait. Feature gate gets removed.
Continued direction of #107. Non-arkworks fields can now use the eq primitives, which were previously unavailable outside the arkworks build.
Changes
The unit tests remain gated on feature = "arkworks" (#[cfg(all(test, feature = "arkworks"))]) because they exercise the arkworks-only F64 test field.
Verification
All pass: cargo build, cargo build --no-default-features, cargo clippy -- -D warnings (both feature configs), cargo fmt --check, and cargo test --all-features (full suite, incl. the 12 hypercube tests).