Repository navigation
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/37977025096. Examine the logs at this URL for more detail. |
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
Updated README to reflect changes in patch file handling.
There was a problem hiding this comment.
Not sure if you want to include it, but one thing I use as a sanity check is that I commit the rebased patches (on the feedstock), and the look at the diff-of-diffs with git show -a (by default, patches are dealt as binary due to line ending issues, and so don't show up in the diff; -a shows the diff regardless). For patches that had no conflicts to fix, nothing but the initial hash should change. This also catches instances where people (often myself 🙈) forgot to restore --author or --date correctly
| # Verify the exported series on a clean checkout of the new tag. | ||
| patched_head=$(git rev-parse HEAD) | ||
| git switch --detach "$new" | ||
| git am *.patch | ||
| git diff "$patched_head" HEAD --exit-code |
There was a problem hiding this comment.
This part makes no sense to me. If we've just generated the patches on top of $new with git format-patch, what possible failure mode are we expecting that would justify this almost-certain-to-be-redundant validation?
Follow-up tweaks from feedback on #938
Once these are approved, I'll port them to the other versions.
CC @isuruf @h-vetinari