feat(backup): back up and restore the encrypted vault from the menu - #16
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The vault is already a single sealed file, so backup is a copy — no new format, no second key. This adds File → Back Up Vault… (
⌘⇧B) and Restore from Backup…, mirrored as buttons in Settings → Backup, with copy that spells out that the copy is encrypted and only the master password opens it (so putting it in iCloud Drive/OneDrive/Dropbox is safe).The app had no menu at all before (
autoHideMenuBar: true+ Electron's default template), somenu.tsadds a real one; the menu is now always visible on Windows/Linux since it carries the backup items.Three things worth calling out in the implementation:
Restore fires
lockedEventso the renderer drops to the unlock screen — the restored file needs the password it was made with, which may not be the current one.totp.code'sTotpEntry | nullfrom #15 is unchanged here; the new IPC surface isbackup.create/restore/revealVault.Link to Devin session: https://app.devin.ai/sessions/04636534e07048089ffb6b78142e12cd
Requested by: @pyramation