fix(desktop): no seam while the vault doors are shut; smaller mark - #20
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
At rest the doors were still two 50%-width panels sitting edge to edge, so a hairline showed down the middle of the locked screen. The panels now only exist while there is motion; shut, the surface is a single element. The mark is also half the size (
22vh, max192px), which reads as elegant rather than a splash screen.The swap is invisible because the face is factored into one
Facethat is always centred on the viewport: sealed it is centred in a full-width element, split each panel clips a viewport-wide copy at the same place, so the pixels are identical on the frame the split happens (which is also the frame the panels start moving). TheboxShadowis now unconditional on the panels for the same reason — panels only render while moving, so it can never be visible at rest. Also drops the seam divider element that used to draw that line deliberately, and moves the controls tobottom-[12vh]to sit with the smaller mark.Verified in the running app: the locked screen is one surface with the mark at 174px (22vh of 793), and sampling
getComputedStyleduring unlock showssealed→splitthentranslateX0 → -637pxover the 560ms ease-out before the panels unmount.Screenshots
Opening and closing, captured from the running app:
Link to Devin session: https://app.devin.ai/sessions/04636534e07048089ffb6b78142e12cd
Requested by: @pyramation