Skip to content

Walk doesn't traverse with clause #216

Closed

Description

@yilinjuang

Since withClause has type WithClause and walk only handles Node type, the entire withClause is skipped.

https://github.com/launchql/pgsql-parser/blob/7e4343a796a48a61b3272654c3a05af3b3f9514a/packages/traverse/src/17/runtime-schema.ts#L8514-L8519

https://github.com/launchql/pgsql-parser/blob/7e4343a796a48a61b3272654c3a05af3b3f9514a/packages/traverse/src/traverse.ts#L72-L83

Same issue applies to union larg and rarg.

Expected behavior

Walk should traverse with clause and union.

Actual behavior

Walk skips with clause and union.

Activity

  1. pyramation commented on Oct 4, 2025

    @pyramation
    Collaborator

    thank you! Super happy to take a PR for this :)

  2. added a commit that references this issue on Nov 23, 2025
    78569b1
  3. added a commit that references this issue on Nov 23, 2025
    df007f1
  4. pyramation commented on Nov 23, 2025

    @pyramation
    Collaborator
  5. pyramation commented on Nov 23, 2025

    @pyramation
    Collaborator

    @yilinjuang pardon the delay, thanks for being patient :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions